Repository navigation
Repair wp/7.1 branch Actions: Use the matching wordpress-develop branch for pre-release PHPUnit tests - #84760
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
🤖 PR meta 🤖📦 Bundle sizeSize Change: 0 B Total Size: 7.75 MB
|
69d22ea to
72e1480
Compare
ramonjd
left a comment
There was a problem hiding this comment.
| Base PR #84743 | This PR #84760 | |
|---|---|---|
| Unit Tests → PHP jobs | fail | all 7 pass |
| PHP 8.0 on Linux | Error in bootstrap script: Error: Interface "WP_Secrets_Store" not found |
Tests: 2279, Assertions: 4760, Skipped: 7, Risky: 1 |
| New Jest tests | not present | PASS packages/env/lib/test/download-wp-phpunit.js |
Manually inspected "Unit Tests > PHP 8.0 on Linux" CI jobs
Part of #82781.
What?
Backports #84758 (2266724) to this branch's
wp-env: the PHPUnit test library for a WordPress alpha, beta or RC version now comes from that version'sX.Ybranch ofWordPress/wordpress-developwhen the branch exists, and only falls back to trunk when it doesn't. Released versions still use their tag.Why?
This branch's
wp-envconfig uses"core": "WordPress/WordPress#7.1-branch", which reports7.1.4-alpha-64164since the post-7.1.3 version bump. Because of the-alpha,wp-envdownloads trunk's test library instead of 7.1's.On 2026-10-13, WordPress/wordpress-develop@5744bc5 added the Secrets API to trunk, and trunk's
tests/phpunit/includes/bootstrap.phpnow loads aMock_Store implements WP_Secrets_Storetest helper.7.1-branchhas noWP_Secrets_Store, so every PHP unit test job on this branch stops before running a test (https://github.com/WordPress/gutenberg/actions/runs/38666544526):With this change,
7.1.4-alpha-64164gets the7.1branch ofWordPress/wordpress-develop, whose test library matches7.1-branch.How?
Same change as #84758 in
packages/env/lib/runtime/docker/download-wp-phpunit.js, adapted to this branch:getTestSuiteRefs()turns the version fromwp-includes/version.phpinto the refs to try, in order: theX.Ybranch and then trunk for a pre-release, the tag and then theX.Ybranch for a release, in case the tag does not exist yet.fetchTestSuite()lists the refs that exist with a singlegit ls-remotecall, fetches the first one, and checks outFETCH_HEAD, so a cached test library also moves to what was just fetched. It does not read git's error messages, which are translated in other locales.wp-env, instead of Vitest. Thesimple-gitv3 default import this branch uses stays as it is.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code