Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
- `Modal`: Keep an accessible name on the dialog when `title` is combined with `__experimentalHideHeader`. The heading that `aria-labelledby` referenced is not rendered in that case, so the title is now applied as the dialog's `aria-label` instead ([#82645](https://github.com/WordPress/gutenberg/pull/82645)).
- `ColorPicker`: Make the HSL and RGB input labels translatable, and name the Hue and Alpha inputs after their color format ([#70214](https://github.com/WordPress/gutenberg/pull/70214)).
- `CustomGradientPicker`: Use the bundled `gradient-parser` types, preserve gradient angles when editing, and keep unsupported gradient syntax on the existing fallback path ([#84582](https://github.com/WordPress/gutenberg/pull/84582)).
- `BaseControl`: Remove the unsupported `as` prop from the component types and documentation ([#70064](https://github.com/WordPress/gutenberg/pull/70064)).

### Internal

Expand Down
7 changes: 0 additions & 7 deletions packages/components/src/base-control/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,6 @@ const MyCustomTextareaControl = ({ children, ...baseProps }) => (

## Props

### `as`

- Type: `"symbol" | "object" | "a" | "abbr" | "address" | "area" | "article" | "aside" | "audio" | "b" | ...`
- Required: Yes

The HTML element to render the component as.

### `className`

- Type: `string`
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/base-control/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { contextConnectWithoutRef, useContextSystem } from '../context';
export { useBaseControlProps } from './hooks';

const UnconnectedBaseControl = (
props: WordPressComponentProps< BaseControlProps, null >
props: WordPressComponentProps< BaseControlProps, null, false >
Comment thread
ciampo marked this conversation as resolved.
Resolved
) => {
const {
id,
Expand Down
1 change: 0 additions & 1 deletion storybook/components-manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@
- name: BaseControl
props:
- __nextHasNoMarginBottom
- as
- children
- className
- help
Expand Down
Loading