Skip to content

Fix - Add margin block support to the core/query-pagination block. - #68429

Closed
prasadkarmalkar wants to merge 1 commit into
WordPress:trunkfrom
prasadkarmalkar:update/query-pagination-margin-support
Closed

prasadkarmalkar wants to merge 1 commit into
WordPress:trunkfrom
prasadkarmalkar:update/query-pagination-margin-support

Conversation

@prasadkarmalkar

Copy link
Copy Markdown
Contributor

What?

Fixes: #68428

Screenshots or screencast

Screenshot 2024-12-31 at 11 22 45 AM

@github-actions

github-actions Bot commented Dec 31, 2024 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: prasadkarmalkar <prasadkarmalkar@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: karthick-murugan <karthickmurugan@git.wordpress.org>
Co-authored-by: daviedR <daviedr@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan added [Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block [Type] Enhancement A suggestion for improvement. labels Jan 10, 2025
@carolinan

Copy link
Copy Markdown
Contributor

Hi @prasadkarmalkar There is already an existing pull request for this #66398
Perhaps you could help test and review it instead?

@carolinan

Copy link
Copy Markdown
Contributor

Hi @prasadkarmalkar @karthick-murugan @rinkalpagdar
There are now five pull requests for this issue that does the same thing, can you please discuss among yourself which of these tickets that should be continued, so that the issue can be solved.

https://github.com/WordPress/gutenberg/pulls?q=is%3Aopen+is%3Apr+label%3A%22%5BBlock%5D+Query+Pagination%22

@karthick-murugan

karthick-murugan commented Mar 4, 2025 •

Copy link
Copy Markdown
Contributor

Hi @carolinan,

Based on my understanding, the PRs submitted by @rinkalpagdar and me are for distinct blocks: Query Pagination Numbers, Query Pagination Next, Query Pagination Previous, and Query Pagination. We coordinated and divided the work accordingly, referencing the lists from these two main issues:

#43243
#43247

However, if this current PR appears to be a duplicate, please let me know. I appreciate any clarification on this matter.

Looking forward to your feedback.

@carolinan

Copy link
Copy Markdown
Contributor

Thank you, now I understand better!

@t-hamano

t-hamano commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

Sorry, I will close this PR as it is a duplicate of #66398.

@t-hamano t-hamano closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add margin block support to the core/query-pagination block.

4 participants