Zoom Out: Move the hook to the inserter component #63315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unning on each mount of the pattern category preview panel
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
added
the
[Feature] Inserter
|
Probably should resolve #63168 as well. |
|
Size Change: +2 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b1ff9bd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9859847909
|
This was referenced Jul 10, 2024
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jul 10, 2024
…unning on each mount of the pattern category preview panel (WordPress#63315) Co-authored-by: scruffian <[email protected]> Co-authored-by: jeryj <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: MaggieCabrera <[email protected]>
|
Hey @scruffian, thanks for working on this! I'm testing it on the v18.8.0-rc.2 release. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…unning on each mount of the pattern category preview panel (WordPress#63315) Co-authored-by: scruffian <[email protected]> Co-authored-by: jeryj <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: MaggieCabrera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #62707.
Runs the hook in the inserter component so it doesn't keep running on each mount of the pattern category preview panel.
Why?
This prevents the continual running of the hook when mounting and unmounting the pattern preview component.
How?
Moves the hook back to the inserter component.
Testing Instructions
Do the same in the post editor.
Screenshots or screencast
Jul-09-2024.16-22-12.mp4