Hide the presets panel for when there are less or exactly one presets available #62074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +10 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
I like seeing this happen. Because here is what my theme currently looks like with one preset showing:
|
draganescu
added
[Type] Bug
draganescu
force-pushed
the
add/hide-presets-for-one-or-less
branch
from
cd8c039
to
830a5ea
Compare
|
@draganescu Just tested this, and it appears to remove everything except the Default variation. I would expect this to do the exact opposite, which is remove the Default variation, showing just the Color and Typography presets.
|
|
I pushed a tweak to the logic to return null if there is only one (or less) variation, which is the default.
|
|
A leftover I didn't pay attention to but which tested fine because:
... oops! |
|
@richtabor @draganescu Quick note to mention that the Default style variation still is shown, though the Color preset seems to be highlighted (which I love). Additionally, the Typography preset is no longer being shown. (There is only one.)
|
We want the default variation (not the typography/colors, but the global one) to show as an easy way for the user to reset their own changes too |
This does not affect the default variation, only does not render the "Presets" UI if there are no alternate variations to switch to. Defaults were added in #61901.
|
Confirming this is now true with my experience with Powder:
|
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@richtabor @draganescu @MaggieCabrera @ajlende Are we waiting for anything else at this point to GTM? (Besides final reviews?) |
|
This failing test that says ... |
Try rebasing, #62111 should have fixed that |
draganescu
force-pushed
the
add/hide-presets-for-one-or-less
branch
from
72354fe
to
811eadd
Compare
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…rdPress#62074) * hide the presets panel for when there are less or exactly one presets available * tweak logic to return null if there is only one variation (the default). --------- Co-authored-by: draganescu <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: MaggieCabrera <[email protected]> Co-authored-by: bgardner <[email protected]> Co-authored-by: hbhalodia <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…rdPress#62074) * hide the presets panel for when there are less or exactly one presets available * tweak logic to return null if there is only one variation (the default). --------- Co-authored-by: draganescu <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: MaggieCabrera <[email protected]> Co-authored-by: bgardner <[email protected]> Co-authored-by: hbhalodia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #61216
Why?
A palette should have more than one item, particularly when that item is also used as a default.
How?
Update the components that show the type sets and color sets to now show if there is only one or zero presets.
Testing Instructions
wp-contentand remove thestylesfolderTesting Instructions for Keyboard
N/A
Screenshots or screencast
CleanShot.2024-05-29.at.13.22.01.mp4