Global Styles: Restore the default variation to the color and typography style tiles #61901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Enhancement
youknowriad
reviewed
May 23, 2024
| // Remove variations that are empty once the property is filtered out. | ||
| if ( Object.keys( variationFilteredByProperty ).length === 0 ) { | ||
| if ( | ||
| variation.title !== 'Default' && |
There was a problem hiding this comment.
If I'm not wrong, this is a translated string so it might break. We could test __( 'Default' ) instead but I wonder if there's a better way to identify this (a flag or something)
There was a problem hiding this comment.
Good catch. We do this elsewhere too:
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +87 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2cfcf6b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9211097299
|
youknowriad
approved these changes
May 23, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…phy style tiles (WordPress#61901) * Global Styles: Restore the default variation to the color and typography style tiles * find the default variation with i18n Co-authored-by: scruffian <[email protected]> Co-authored-by: youknowriad <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…phy style tiles (WordPress#61901) * Global Styles: Restore the default variation to the color and typography style tiles * find the default variation with i18n Co-authored-by: scruffian <[email protected]> Co-authored-by: youknowriad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This restores the default variation to the style tiles for color and typography sets.
Why?
This is necessary to allow users to put their color and typography settings back to how they were before they made changes.
How?
Don't filter out Default as an empty variation - treat it as an exception.
Testing Instructions
Screenshots or screencast