Edit post: Do not consider sidebars mutually exclusive #61468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Code Quality
|
Size Change: -52 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
I wonder what was the original point in having this behaviour in the post editor? |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
I'd guess to have more space for the editor. It was implemented years ago and actually we don't even have the same behavior when opening the list view - it doesn't close the inspector controls sidebar. |
richtabor
approved these changes
May 8, 2024
carolinan
approved these changes
May 8, 2024
|
haha, this is the same as #60062 and there's an e2e test failure that I didn't understand yet. |
ntsekouras
force-pushed
the
edit-post/remove-mutually-exclussive-sidebars-handling
branch
from
3aafc87
to
ae25350
Compare
Sorry about that @youknowriad! I had missed your PR.. The failure was weird and was probably also related with playwright I think, because there was still visible part of the placeholder to drop.. I decided on a simple workaround for now, since we are going to try the zoom out view for media categories really soon.. |
ntsekouras
force-pushed
the
edit-post/remove-mutually-exclussive-sidebars-handling
branch
from
ae25350
to
49560b9
Compare
ntsekouras
deleted the
edit-post/remove-mutually-exclussive-sidebars-handling
branch
|
This PR impacted several performance metrics. I think we're probably testing with the sidebar open for these metrics so we need to ensure we close the sidebar (or the inserter) before actually testing. |
ellatrix
reviewed
Jun 26, 2024
| @@ -659,7 +659,7 @@ test.describe( 'Post Editor Performance', () => { | |||
|
|
|||
| const startTime = performance.now(); | |||
|
|
|||
| await page.getByText( 'Test' ).click(); | |||
| await page.getByRole( 'tab', { name: 'Test' } ).click(); | |||
There was a problem hiding this comment.
@ntsekouras I'm curious why you changed this? It's causing the performance tests to fail for 6.5, where this had the role of a button.
There was a problem hiding this comment.
I think there were two elements with the test and we wanted that tab one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the handling in post editor that considers the sidebars mutually exclusive. This is now consistent with site editor.
Testing Instructions