Post Editor: Do not close the sidebar when opening the inserter #60062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
jasmussen,
richtabor,
jorgefilipecosta and
ntsekouras
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @porg. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -65 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
@youknowriad, it would be nice to get your feedback on #60004. |
|
The e2e test failure is related to these changes. The canvas is too obscured for drag and drop. Screenshot
|
|
It seems we could consider separately exploring hiding the inserter temporarily when dragging items. |
|
Makes sense to me, at the very least as a step towards unification. I'd also think improvements we can make is to explore size tweaks to the inserter, potentially it can be contextually smaller. |
Or instead of the whole inserter, just the secondary "Media" and "Patterns" sidebar views. But then again, #60004 would help to resolve this, as we lean into engaging zoom out when a pattern category is selected (#44585) and perhaps when a media category is enabled. We just need to shift the canvas when Media is engaged, like we did for patterns. |
youknowriad
force-pushed
the
update/mutuality-exclusive-sidebars
branch
from
3ad36b1
to
0178cec
Compare
youknowriad
force-pushed
the
update/mutuality-exclusive-sidebars
branch
from
0178cec
to
7683e4c
Compare
|
Flaky tests detected in 7683e4c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8837128388
|
|
Closing in favor of #61468 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #23968
What?
In the post editor, it's not possible to keep the right sidebar open when inserting blocks. This has been implemented because of the big space that both of these sidebars can take. That said, this behavior is not present in the site editor and it hasn't really proved to be problematic while the behavior in the post editor has surfaced issues like #23968
In this PR, I'm removing this particular behavior from the post editor and just aligning with the site editor.
Testing Instructions