Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Logo: Add setting labels via the 'register_setting' method #61351

Merged
merged 1 commit into from
May 3, 2024

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented May 3, 2024

What?

PR updates the Site Logo block to provide setting labels via the registration function instead of using the shim.

Why?

Unlike other core settings, these are associated with the block and must be synced via package updates. I remembered this while working on WordPress/wordpress-develop#6495.

Testing Instructions

  1. Open a post.
  2. Add a Site Logo block.
  3. Select an image.
  4. Save the post.
  5. Confirm setting labels are correctly displayed.

Testing Instructions for Keyboard

Same.

Screenshots or screencast

CleanShot 2024-05-03 at 12 55 31

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Block] Site Logo Affects the Site Logo Block labels May 3, 2024
@Mamaduka Mamaduka self-assigned this May 3, 2024
@Mamaduka Mamaduka requested a review from t-hamano May 3, 2024 09:04
Copy link

github-actions bot commented May 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Mamaduka
Copy link
Member Author

Mamaduka commented May 3, 2024

Thanks for testing, @t-hamano!

@Mamaduka Mamaduka merged commit 5d981a3 into trunk May 3, 2024
67 checks passed
@Mamaduka Mamaduka deleted the update/site-logo-setting-labels branch May 3, 2024 15:18
@github-actions github-actions bot added this to the Gutenberg 18.4 milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Logo Affects the Site Logo Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants