Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP backports for WP 6.6 #61226

Closed
ellatrix opened this issue Apr 30, 2024 · 21 comments
Closed

PHP backports for WP 6.6 #61226

ellatrix opened this issue Apr 30, 2024 · 21 comments
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Project Management Meta-issues related to project management of Gutenberg [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@ellatrix
Copy link
Member

ellatrix commented Apr 30, 2024

We'd like to start backporting the necessary PHP code as soon as possible to catch issues early so that it doesn't block the package release process.

Thank you!


📁 lib

📁 compat

📁 wordpress-6.6

📁 wordpress-6.5

📁 wordpress-6.4


📁 block-supports

📄 layout.php

📄 elements.php

📄 typography.php

- [ ] #59531 - @t-hamano | Trac ticket | Core backport PR
See below.

📄 background.php

- [ ] #59889 - @ramonjd | Trac ticket | Core backport PR
See below.
- [ ] #59354 - @ramonjd | Trac ticket | Core backport PR
See below.
- [ ] #61387 - @ramonjd | Trac ticket | Core backport PR
See below.

📄 shadow.php

📄 duotone.php

📄 block-style-variations.php


📁 experimental

📄 editor-settings.php

📄 kses.php

📄 blocks.php


📄 class-wp-theme-json-gutenberg.php


📄 class-wp-theme-json-data-gutenberg.php


📄 class-wp-rest-global-styles-controller-gutenberg.php


📄 class-wp-theme-json-schema-gutenberg.php


📄 global-styles-and-settings.php


📄 interactivity-api.php


📄 class-wp-duotone-gutenberg.php


📄 blocks.php


📄 client-assets.php


📁 phpunit

The rest is tracked in items above, not sure why these are duplicated.

📁 packages

📁 style-engine

📄 class-wp-style-engine-css-rule.php


People

@ellatrix ellatrix added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Project Management Meta-issues related to project management of Gutenberg [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. labels Apr 30, 2024
@Mamaduka
Copy link
Member

I already have a backport ticket for my items. I'll try to finalize it this week. Ticket - https://core.trac.wordpress.org/ticket/61023.

@oandregal
Copy link
Member

I've marked #60813 as done and left a comment: this is gutenberg-only code that doesn't need to be backported.

@colinduwe
Copy link
Contributor

Here's the backport ticket for shadow.php
https://core.trac.wordpress.org/ticket/60784

@tellthemachines
Copy link
Contributor

I have a draft in progress for the style engine changes; updated the description with the link.

At this point it's unlikely that #59483 and #60652 will be added to core. I've left them on the list so we know they weren't missed but crossed them out with a note.

Also, I think everything inside editor-settings.php can safely be ignored? It's all related to adding and removing Gutenberg experiments.

@aaronrobertshaw
Copy link
Contributor

There's a single backport (WordPress/wordpress-develop#6214) to cover both #59535 & #59538 for the elements block support.

@t-hamano
Copy link
Contributor

t-hamano commented May 2, 2024

I added #61080 to the list.

@aaronrobertshaw
Copy link
Contributor

aaronrobertshaw commented May 2, 2024

@tellthemachines
Copy link
Contributor

Draft for grid column and row spans here, still needs adding tests.

@fabiankaegy
Copy link
Member

I added #47271 to the list

@petitphp
Copy link
Contributor

PR Block editor: localize search suggestions' post type in LinkControl component is ready to be merged.

Associated backport is available : Trac ticket | Core backport PR

@scruffian
Copy link
Contributor

Added a PR and a ticket for the theme JSON changes.

@scruffian
Copy link
Contributor

Added a PR and a trac ticket for the Duotone backport.

@joemcgill
Copy link
Member

Not sure where this belongs, necessarily, but #61262 is being applied to Core in https://core.trac.wordpress.org/ticket/61112.

@aaronrobertshaw
Copy link
Contributor

Added a PR and trac ticket for extension to block style registration.

@ellatrix
Copy link
Member Author

Updated the issue with the latest PRs until today.

@t-hamano
Copy link
Contributor

Just a question; Should we add the gutenberg-merge keyword to the core ticket? I couldn't find any documentation about this label.

Similar question on Slack: https://wordpress.slack.com/archives/C02QB2JS7/p1716533231110759?thread_ts=1716367176.433729&cid=C02QB2JS7

@tellthemachines
Copy link
Contributor

@t-hamano yes the Trac ticket should have the gutenberg-merge keyword. It's not in the dropdown but there's an option to add keywords manually. It's been in use for maybe a year or two now, but unsure if it was ever documented - the processes around merging GB to Core keep evolving so documentation tends to quickly become outdated 😅

@aaronrobertshaw
Copy link
Contributor

There's a new backport PR available to cover all the global styles CSS specificity changes from the following Gutenberg PRs:

I've updated the issue description acordingly.

@tellthemachines
Copy link
Contributor

tellthemachines commented May 29, 2024

👀 I see that #60716 hasn't been done yet, I'll put up a quick PR for that one!

Edit: done in WordPress/wordpress-develop#6664

@aaronrobertshaw
Copy link
Contributor

Added a PR and Ticket for section styles backport.

@ellatrix
Copy link
Member Author

ellatrix commented Jun 4, 2024

All backports for Beta 1 are done. In time, I'll create a new (smaller) issues with any new backports for Beta 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Project Management Meta-issues related to project management of Gutenberg [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

No branches or pull requests