Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block editor canvas: use focusMode instead of editorPadding #58527

Closed
wants to merge 3 commits into from
Closed

Block editor canvas: use focusMode instead of editorPadding #58527

wants to merge 3 commits into from

Commits on Mar 20, 2024

  1. This PR ensures that the iframe background is always white regardless… 

    … of whether it has "padding". Because the background of the visual editor is $gray-900, we use a border to mimic existing padding.
    @ramonjd
    ramonjd committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    191fb57 View commit details
    Browse the repository at this point in the history

  2. Reverts first attempt and now tries to harmonize the editor canvas is… 

    …-focus-mode between site and post editors. By "harmonize", I mean use the same approach by driving the padding via a classname `is-focus-mode` on the edit-${site/post}-layout element, not centralize the code. The latter is difficult because the site editor has "modes", such as edit and view, which also affect the styles.

Reverts first attempt and now tries to harmonize the editor canvas is-focus-mode between site and post editors. By "harmonize", I mean use the same approach by driving the padding via a classname `is-focus-mode` on the edit-${site/post}-layout element, not centralize the code. The latter is difficult because the site editor has "modes", such as edit and view, which also affect the styles.
    @ramonjd
    ramonjd committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    aca4127 View commit details
    Browse the repository at this point in the history

  3. No need for transparent background as we're editing the pattern in place 

    rebase
    @ramonjd
    ramonjd committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    a798e23 View commit details
    Browse the repository at this point in the history