Block editor canvas: use focusMode instead of editorPadding #58527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Bug
|
Size Change: -31 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
ramonjd
commented
Feb 1, 2024
andrewserong
reviewed
Feb 1, 2024
ramonjd
force-pushed
the
update/iframe-padding-border
branch
from
44bc6ee
to
de12144
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
force-pushed
the
update/iframe-padding-border
branch
from
de12144
to
63e4b3f
Compare
ramonjd
commented
Feb 1, 2024
| @@ -27,14 +27,6 @@ | |||
| // Centralize the editor horizontally (flex-direction is column). | |||
| align-items: center; | |||
|
|
|||
| // Controls height of editor and editor canvas container (style book, global styles revisions previews etc.) | |||
| iframe { | |||
There was a problem hiding this comment.
The styles are the same across editors so I centralized them in packages/block-editor/src/components/block-canvas/style.scss.
If there's any reason to have bespoke styles I guess they can be overwritten in the site or post editor packages (?)
ramonjd
commented
Feb 1, 2024
| background-color: $white; | ||
| } | ||
|
|
||
| iframe[name="editor-canvas"].has-editor-padding { | ||
| padding: $grid-unit-60 $grid-unit-60 0; |
There was a problem hiding this comment.
Removed bottom padding to match what the style editor already has:
ramonjd
commented
Feb 1, 2024
| iframeProps={ { | ||
| style: { | ||
| background: isEditingPattern | ||
| ? 'transparent' |
There was a problem hiding this comment.
This is the magic that removes the background and only highlights the pattern being edited. This is current behaviour in trunk.
To be effective however, it relies on the pattern having a background of its own.
2024-02-02.10.38.08.mp4
cc @glendaviesnz for confirmation
There was a problem hiding this comment.
Actually I'm thinking we ditch the transparent background.
ramonjd
changed the title
… of whether it has "padding". Because the background of the visual editor is $gray-900, we use a border to mimic existing padding.
…-focus-mode between site and post editors. By "harmonize", I mean use the same approach by driving the padding via a classname `is-focus-mode` on the edit-${site/post}-layout element, not centralize the code. The latter is difficult because the site editor has "modes", such as edit and view, which also affect the styles.
Reverts first attempt and now tries to harmonize the editor canvas is-focus-mode between site and post editors. By "harmonize", I mean use the same approach by driving the padding via a classname `is-focus-mode` on the edit-${site/post}-layout element, not centralize the code. The latter is difficult because the site editor has "modes", such as edit and view, which also affect the styles.
ramonjd
force-pushed
the
update/iframe-padding-border
branch
from
ca21493
to
a798e23
Compare
ramonjd
changed the title
ramonjd
added
[Type] Code Quality
|
Closing this PR as the original bug has been addressed. There's still an outstanding disunity in the way we determine "focus mode" across the editors, and therefore the padding. In the site editor, it's partly set according to whether the currently-edited template is in the FOCUSABLE_ENTITIES array. This PR in its current state attempts to steer things in the latter direction. In the post editor however, a I think it should and can be harmonized still, with a tendency towards detecting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #57631
This PR ensures that the iframe background is always white regardless of whether it has "padding".
Why?
Normally, the iframe has a white background.
When editing a template in the post editor, the iframe receives a classname of
.has-editor-padding- this class is excluded from receiving the white background via thenot()selector.Here's the post editor in trunk:
2024-02-01.12.22.46.mp4
How?
This PR tries to harmonize the editor canvas
.is-focus-modebetween site and post editors.By "harmonize", I mean use the same approach by driving the padding via a classname
is-focus-modeon the edit-${site/post}-layout element, not centralize the code.The latter is difficult because the site editor has "modes", such as edit and view, which also affect the styles.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Post editor editing post template
Post editor editing original synched pattern
Site editor editing page template