Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterate on warning text for block removal for query/post template/post content #58138

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Iterate on warning text for block removal for query/post template/post content #58138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
191b28f
Iterate on warning text for block removal for query/post template/pos…
annezazu Jan 23, 2024
aba12de
Adjust string
richtabor Jan 23, 2024
0887844
Update block-removal.spec.js
richtabor Jan 23, 2024
8428385
Update e2e test
andrewserong Jan 23, 2024
ee1fa1a
Give the modal a max-width to be consistent with block lock modal
andrewserong Jan 23, 2024
8ff893b
Use modal size prop
andrewserong Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/block-editor/src/components/block-removal-warning-modal/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,12 @@ export function BlockRemovalWarningModal( { rules } ) {
<Modal
title={ __( 'Be careful!' ) }
onRequestClose={ clearBlockRemovalPrompt }
size="medium"
>
<p>
{ _n(
'Post or page content will not be displayed if you delete this block.',
'Post or page content will not be displayed if you delete these blocks.',
'Deleting this block will stop your post or page content from displaying on this template. It is not recommended.',
'Deleting these blocks will stop your post or page content from displaying on this template. It is not recommended.',
blockNamesForPrompt.length
) }
</p>
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/specs/site-editor/block-removal.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ test.describe( 'Site editor block removal prompt', () => {
// Expect the block removal prompt to have appeared
await expect(
page.getByText(
'Post or page content will not be displayed if you delete these blocks.'
'Deleting these blocks will stop your post or page content from displaying on this template. It is not recommended.'
)
).toBeVisible();
} );
Expand All @@ -59,7 +59,7 @@ test.describe( 'Site editor block removal prompt', () => {
// Expect the block removal prompt to have appeared
await expect(
page.getByText(
'Post or page content will not be displayed if you delete this block.'
'Deleting this block will stop your post or page content from displaying on this template. It is not recommended.'
)
).toBeVisible();
} );
Expand Down
Loading