Iterate on warning text for block removal for query/post template/post content #58138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t content Addresses continued feedback on #52392
annezazu
added
[Type] Enhancement
|
Size Change: +349 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
The copy reads well to me, nice idea! Here's how it's looking:
Singular
Plural
One minor concern is that the text now runs on a fair way horizontally, whereas previously the modal was a bit narrower:
Trunk
Should we contain the text a bit?
Would it be worth adding some max-width or something to the paragraph so that it's a bit more contained? E.g. so that it could look a bit more like this:
@richtabor what do you think about containing it a little? (Just pinging you since I see you did a couple of commits 🙂)
andrewserong
approved these changes
Jan 23, 2024
|
Oh let's definitely fix that width issue. That's not a good look (and we ran into that in a prior iteration). Do you mind helping me with that change? Went digging. Got lost in the files. |
Sure! I reckon we can add a classname to the |
|
Whoops! There's a simpler way to do it, hold on, I'll push another update 😄 |
|
Hah! I was about to do the classname when I felt like I must be missing something that's been done before. This looks great. Thank you. Going to squash and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Addresses continued feedback on #52392 by updating the copy of the warning.
Closes #52392.
Why?
To address feedback that the current messaging still isn't doing enough to prevent users from deleting blocks that help display content.
How?
Iterates on just the copy.