Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List: Disable edit as HTML support #55656

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

shimotmk
Copy link
Contributor

What?

This PR disables HTML editing support for list blocks.
A similar PRs: #11785, #39318 and #49426.

Why?

Editing these wrapper blocks in HTML directly is fragile and prone to breaking the users' content. HTML editing should be left to leaf-blocks.

#11785 (comment)

Testing Instructions

  1. Open a Post or Page.
  2. Insert a List block.
  3. Confirm "Edit as HTML" action isn't available in block Options.

Screenshots or screencast

list.mp4

@github-actions

This comment was marked as outdated.

@skorasaurus skorasaurus added the [Block] List Affects the List Block label Oct 29, 2023
@Mamaduka Mamaduka added the [Type] Bug An existing feature does not function as intended label Oct 30, 2023
Copy link
Member

@ajitbohra ajitbohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shimotmk
Copy link
Contributor Author

shimotmk commented Jan 9, 2024

@ajitbohra
Could you please merge this pull request?

@ajitbohra ajitbohra enabled auto-merge (squash) January 9, 2024 03:56
@shimotmk
Copy link
Contributor Author

@ajitbohra
Is this something I need to do?
Is it better to rebase the trunk branch?

@shimotmk shimotmk closed this Jan 10, 2024
auto-merge was automatically disabled January 10, 2024 08:49

Pull request was closed

@shimotmk shimotmk deleted the fix/list-disable-html-editing branch January 10, 2024 08:49
@shimotmk shimotmk restored the fix/list-disable-html-editing branch January 10, 2024 09:51
@shimotmk shimotmk reopened this Jan 10, 2024
@shimotmk
Copy link
Contributor Author

I closed it by mistake.🙇‍♂️
Could someone please give a review?

Copy link

github-actions bot commented Apr 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <[email protected]>
Co-authored-by: ajitbohra <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka merged commit d15a114 into WordPress:trunk Apr 3, 2024
54 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.2 milestone Apr 3, 2024
@shimotmk shimotmk deleted the fix/list-disable-html-editing branch April 3, 2024 22:36
cbravobernal pushed a commit to garridinsi/gutenberg that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants