Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude HTML editing from Columns and Column blocks. #11785

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

mtias
Copy link
Member

@mtias mtias commented Nov 13, 2018

Fixes #11438

Editing these wrapper blocks in HTML directly is fragile and prone to breaking the users' content. HTML editing should be left to leaf-blocks.

Editing these wrapper blocks in HTML directly is fragile and prone
to breaking the users' content.

HTML editing should be left to leaf-blocks.
@mtias mtias added the [Block] Columns Affects the Columns Block label Nov 13, 2018
@mtias mtias added this to the 4.4 milestone Nov 13, 2018
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gziolo
Copy link
Member

gziolo commented Nov 13, 2018

It was super hard to select Column block :)

By the way, if you manage to select it, the icon for the block is mispositioned, cc @jorgefilipecosta @jasmussen :

screen shot 2018-11-13 at 11 05 45

@gziolo gziolo merged commit c206d07 into master Nov 13, 2018
@gziolo gziolo deleted the update/exclude-html-editing-on-columns branch November 13, 2018 10:07
@jasmussen
Copy link
Contributor

It was super hard to select Column block :)

This is intentional because it is not very actionable right now. Next time set focus in the first block in a column, then press up arrow. Or just use the block traversal tool in the toolbar.

I will take a look at the misalignment.

@mtias
Copy link
Member Author

mtias commented Nov 13, 2018

@gziolo easiest way to select the intermediary column is by using the block navigator in the header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants