Query Loop: Add design enhancements for the "enhanced pagination" setting #54455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +94.4 kB (+6%) 🔍 Total Size: 1.62 MB
ℹ️ View Unchanged
|
DAreRodz
added
[Block] Query Loop
luisherranz
reviewed
Sep 14, 2023
packages/block-library/src/query/edit/enhanced-pagination-modal.js
Outdated
Show resolved
Hide resolved
packages/block-library/src/query/edit/inspector-controls/enhanced-pagination-control.js
Outdated
Show resolved
Hide resolved
|
This is ready for review. @jasmussen, I've added you as a reviewer, as you proposed most of the changes. 🙂 |
luisherranz
reviewed
Sep 14, 2023
24 tasks
|
Nice work, lots of improvements. Without diving too deep into testing, I appreciate the video you shared. In an older video I saw gray placeholders where the images were being loaded, were those removed? I think it can be fine to keep them to indicate "an image will appear here", I think they key is to make them very light colored, and ideally |
Oh, right. That's not part of the enhanced navigation feature. I'm sure @luisherranz added those placeholders manually, just moving the featured images inside a Group block with a custom background color. |
Co-authored-by: Luis Herranz <[email protected]>
Co-authored-by: Luis Herranz <[email protected]>
|
Flaky tests detected in 4e5760d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6188939516
|
SantosGuillamot
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
I've been reviewing this and, apart from the comments already left, it seems everything in the issue has been covered and works great 👏 .
This reverts commit fe52845.
DAreRodz
deleted the
update/interactivity-api-enhanced-pagination-design-tweaks
branch
6 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR addresses most of the tasks listed in #54414 to improve the design of Query Loop's enhanced pagination setting.
Why?
To improve the feature design.
How?
Please take a look at the code changes; they're pretty easy to follow. 🙂
Regarding the loading bar animation, I tried to use an animation timing function that reaches the midpoint in 1-2 seconds approx., and the final point after 30 seconds.
This animation is also disabled when reduced motion is preferred.
Testing Instructions
For the editor changes:
Enhanced pagination will be disabledOKOKFor the loading bar animation:
1.Screenshots or screencast
Screen.Recording.2023-09-14.at.11.17.59.mov
Screen.Recording.2023-09-14.at.11.45.34.mov