Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query block enhanced pagination: additional design enhancements #54414

Closed
6 tasks done
luisherranz opened this issue Sep 13, 2023 · 2 comments
Closed
6 tasks done

Query block enhanced pagination: additional design enhancements #54414

luisherranz opened this issue Sep 13, 2023 · 2 comments
Assignees
Labels
[Block] Query Loop Affects the Query Loop Block [Feature] Interactivity API API to add frontend interactivity to blocks. [Type] Enhancement A suggestion for improvement.

Comments

@luisherranz
Copy link
Member

luisherranz commented Sep 13, 2023

@jasmussen shared with us some design improvements for the Query block enhanced pagination.

These should be pretty fast to do and we should be able to complete them before the 16.7 RC:

  • Change the modal text to: Plugin blocks are not supported. For enhanced pagination to work, remove the plugin block, then re-enable it in settings.
  • Change the modal button text to: OK
  • Change the error notice text to: Enhanced pagination only works with the blocks bundled with WordPress. If you want to enable it, you have to remove all plugin blocks from the Query Loop.
  • Remove the left/right margin of the error notice yellow box so it lines up with the text above.
  • Start the loading bar further to the left.
  • Increase the loading bar starting delay from 300ms to 400ms.

These are more complex and could be done if we have time before the 16.7 RC:

  • Figure out if we can combine the focus scroll with the smooth scroll of scrollIntoView, but we can investigate.
  • Add a “blink” the Query block in the Editor as soon as the toggle is enabled, just to provide some visual feedback in the canvas that something changed.
  • Add a fading animation to the enhanced Query Loop navigation
@jasmussen
Copy link
Contributor

Thanks for capturing this! Some of these are in the suggestions/questions category, and in general there's wiggleroom here.

@luisherranz
Copy link
Member Author

Closed by #54455. I've moved the remaining tasks to the tracking issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Feature] Interactivity API API to add frontend interactivity to blocks. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants