-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update background color of post editor when viewing mobile or tablet viewports, or in template mode #50361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…viewports, or in template mode
talldan
added
[Type] Enhancement
A suggestion for improvement.
[Package] Edit Post
/packages/edit-post
labels
May 5, 2023
Size Change: -2 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
glendaviesnz
approved these changes
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested well for me. Background color of #1e1e1e
displays correctly for tablet and mobile view.
I couldn't see where the .interface-interface-skeleton__content
value might be used, but no harm including it that I can see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #50341
Updates background color of post editor when viewing mobile or tablet viewports, or in template mode.
Also updates a similar style in the site editor, though it's not clear to me if that's ever visible.
Testing Instructions
Screenshots or screencast