Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Editor: Requires default white background #56981

Closed
t-hamano opened this issue Dec 12, 2023 · 3 comments · Fixed by #57330
Closed

Post Editor: Requires default white background #56981

t-hamano opened this issue Dec 12, 2023 · 3 comments · Fixed by #57330
Assignees
Labels
[Package] Edit Post /packages/edit-post [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@t-hamano
Copy link
Contributor

Description

If a theme does not define a background color, you will see a black background in the Post Editor, making the text almost invisible. This issue does not occur on WP6.4.2 with the latest Gutenberg disabled.

The Site Editor applies a white background as a fallback. Like the Site Editor, the Post Editor also requires a white background as a fallback.

Similar PRs have been submitted in the past.

Step-by-step reproduction instructions

  • Enable Emptytheme. This theme does not define a background color in theme.json.
  • The Post Editor should have a black background color.
  • The Site Editor should have a white background color.

Screenshots, screen recording, code snippet

544aed0983d52e4fae5eee2b10fcde56.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release [Package] Edit Post /packages/edit-post labels Dec 12, 2023
@ramonjd
Copy link
Member

ramonjd commented Dec 22, 2023

I think maybe the background color for the .edit-post-visual-editor was introduced here: #50361

@talldan what do you think about perhaps making the default background color of the iframe.editor-canvas $white?

I think it still achieves what the original PR set out to do?

Screenshot 2023-12-22 at 3 44 58 pm

@talldan
Copy link
Contributor

talldan commented Dec 22, 2023

I think maybe the background color for the .edit-post-visual-editor was introduced here: #50361

Not something that I introduced, I modified to a slightly different shade in that PR.

I don't really know much of the background (ahem) of the background colors, so not sure I can lend good advice here. I think I did notice there were a couple of elements that had background colors, but I decided to tread lightly in that PR!

@ramonjd
Copy link
Member

ramonjd commented Dec 22, 2023

Ah, apologies. Thanks for the context though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Edit Post /packages/edit-post [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants