Skip iframe-inline-styles e2e test #50320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
approved these changes
May 4, 2023
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
23 tasks
hellofromtonya
added
the
Backport to Gutenberg Minor Release
|
@bph this PR needs to be cherry-picked for the |
|
I just cherry-picked this PR to the release/15.7 branch to get it included in the next release: 4abb326 |
bph
pushed a commit
that referenced
this pull request
May 9, 2023
bph
removed
the
Backport to Gutenberg Minor Release
|
@oandregal Did #50185 not fix this? |
|
Why was this merged? Was this still failing after #50185? |
|
Yeah I believe it was. I've added #50548 so we can test it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This test fails constantly on PRs that don't touch this code for example:
This disables it.
Why?
So we can merge other PRs.
How?
Using it.skip
Testing Instructions
Check that the tests pass on this PR!