Enable Loginout block in Nav block #49160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Block] Navigation
|
@scruffian I feel like you will know how to best apply the standardised color styling to child blocks of Navigation. Needs to be the same as Page, Submenu...etc but without adding more copy/paste. |
|
Size Change: +19 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Hey any updates on this situation. Are you still working on this. |
Not actively right now. But it is something we'd like to address. |
|
I added the supports to the block to mimic what the nav links are doing. Do we need to do anything else? this looks like it's working as intended |
MaggieCabrera
force-pushed
the
add/loginout-block-in-nav-block
branch
from
aef8f64
to
1bfda88
Compare
|
Ok, I saw about the colors. I don't think we need to do anything for it to work. The controls are on the parent and are being inherited successfully:
|
|
I think all we need is some testing and confirming it works as expected. If it does then we can merge. |
getdave
requested review from
tellthemachines,
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
getdave
commented
Apr 28, 2023
Comment on lines
34
to
+37
| 'core/site-title', | ||
| 'core/site-logo', | ||
| 'core/navigation-submenu', | ||
| 'core/loginout', |
There was a problem hiding this comment.
We should normalize these lists to a single const and import into the relevant files.
scruffian
force-pushed
the
add/loginout-block-in-nav-block
branch
from
1bfda88
to
f2fe127
Compare
|
Flaky tests detected in f2fe127. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4882191188
|
This was referenced May 5, 2023
Closed
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allows for using Login/out block in the Nav block.
Closes #38512
Why?
Because this is a common use case.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast