Fix: OffCanvasEditor does not inserts submenu on collapsed items. #48214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
|
Size Change: +29 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a062253. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4205465909
|
|
Testing this on trunk I see that the link is added to the submenu but the UX is broken, because the submenu does not expand so we don't know something happened. |
draganescu
approved these changes
Feb 20, 2023
draganescu
added
Backport to WP 6.7 Beta/RC
jorgefilipecosta
deleted the
fix/offcanvaseditor-does-not-insert-submenu-on-collapsed-items
branch
ntsekouras
pushed a commit
that referenced
this pull request
Feb 21, 2023
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 4494f13 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on the OffCanvasEditor if a menu item is collapsed and we press "Add submenu" nothing happens. This PR fixes the issue when inserting a submenu now the parent is automatically expanded and we see the UI to create the submenu as expected.
cc: @draganescu