Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] should forward delete across blocks #44353

Closed
github-actions bot opened this issue Sep 22, 2022 · 1 comment · Fixed by #48035
Closed

[Flaky Test] should forward delete across blocks #44353

github-actions bot opened this issue Sep 22, 2022 · 1 comment · Fixed by #48035
Labels
[Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Sep 22, 2022

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

should forward delete across blocks

Test path

/test/e2e/specs/editor/various/multi-block-selection.spec.js

Errors

[2022-09-22T09:26:02.590Z] Test passed after 1 failed attempt on trunk.
[2022-12-16T09:27:17.841Z] Test passed after 1 failed attempt on update/use-select-sync-external-store.
[2022-12-19T11:31:00.150Z] Test passed after 1 failed attempt on fix/focus-high-contrast.
[2022-12-19T14:55:11.022Z] Test passed after 1 failed attempt on optimize/use-available-alignments-array.
[2022-12-19T15:22:56.829Z] Test passed after 1 failed attempt on optimize/use-available-alignments-array.
[2022-12-19T15:34:08.313Z] Test passed after 1 failed attempt on remove/lodash-block-editor-reducer.
[2022-12-20T07:14:48.872Z] Test passed after 1 failed attempt on fix/demo-e2e-cors.
[2022-12-20T09:05:26.219Z] Test passed after 1 failed attempt on fix/demo-e2e-cors.
[2022-12-20T10:12:45.693Z] Test passed after 1 failed attempt on fix/demo-e2e-cors.
[2022-12-22T00:31:06.258Z] Test passed after 1 failed attempt on add/attribute-sourcer.
[2022-12-22T13:07:23.405Z] Test passed after 1 failed attempt on trunk.
[2022-12-23T05:03:47.476Z] Test passed after 1 failed attempt on try/user-global-styles-revisions.
[2022-12-25T22:49:41.171Z] Test passed after 2 failed attempts on try/list-view-modify-shortcut-focus.
[2022-12-27T22:58:11.598Z] Test passed after 1 failed attempt on remove/__experimentalHasMultipleOrigins-property.
[2022-12-29T17:12:14.996Z] Test passed after 1 failed attempt on rnmobile/add-block-insertion-tests.
[2023-01-02T13:38:42.202Z] Test passed after 1 failed attempt on wp/latest.
[2023-01-03T14:16:18.445Z] Test passed after 1 failed attempt on fix/dashicon-remove-unnecessary-classname-type.
[2023-01-04T10:11:09.327Z] Test passed after 1 failed attempt on add/navigation-playwright-tests.
[2023-01-04T12:10:53.951Z] Test passed after 1 failed attempt on add/navigation-playwright-tests.
[2023-01-04T12:24:29.870Z] Test passed after 1 failed attempt on trunk.
[2023-01-04T20:50:33.048Z] Test passed after 1 failed attempt on revert-46314-try/white-default-site-visual-editor.
[2023-01-05T16:31:12.068Z] Test passed after 1 failed attempt on add/get-attribute-names-with-prefix.
[2023-01-06T07:02:04.556Z] Test passed after 1 failed attempt on fix/unify-convert-to-links-behavior.
[2023-01-06T13:37:29.670Z] Test passed after 1 failed attempt on enable/react-18-concurrent-mode.
[2023-01-10T08:15:03.528Z] Test passed after 1 failed attempt on trunk.
[2023-01-10T18:11:22.181Z] Test passed after 1 failed attempt on try/custom-label-to-nav-block-list-view-appender.
[2023-01-11T02:55:45.348Z] Test passed after 1 failed attempt on update/stabilize-block-inspector-tabs.
[2023-01-11T13:52:27.713Z] Test passed after 1 failed attempt on enable/react-18-concurrent-mode.
[2023-01-13T09:21:35.866Z] Test passed after 1 failed attempt on trunk.
[2023-01-16T14:12:00.091Z] Test passed after 1 failed attempt on rename/attribute-updates-to-lexical-updates.
[2023-01-17T07:37:53.695Z] Test passed after 1 failed attempt on fix/47088.
[2023-01-17T10:05:14.436Z] Test passed after 1 failed attempt on trunk.
[2023-01-17T21:07:45.896Z] Test passed after 1 failed attempt on perf/avoid-cloning-in-event-emitter.
[2023-01-19T19:31:28.032Z] Test passed after 2 failed attempts on enable/react-18-concurrent-mode.
[2023-01-20T12:12:07.904Z] Test passed after 1 failed attempt on try/excerpt-length-setting.
[2023-01-24T05:29:27.098Z] Test passed after 1 failed attempt on update/custom-css-move-to-menu.
[2023-01-24T09:05:19.452Z] Test passed after 1 failed attempt on add/has-link-color.
[2023-01-24T15:29:09.012Z] Test passed after 1 failed attempt on trunk.
[2023-01-24T20:24:32.680Z] Test passed after 1 failed attempt on refactor/Notice-typescript.
[2023-01-26T12:50:03.338Z] Test passed after 1 failed attempt on try/enable-off-canvas-nav-editor.
[2023-01-26T16:13:31.610Z] Test passed after 1 failed attempt on refactor/dimension-control-to-typescript.
[2023-01-30T10:30:22.396Z] Test passed after 1 failed attempt on fix/47022.
[2023-01-30T14:52:33.611Z] Test passed after 1 failed attempt on enable/react-18-concurrent-mode.
[2023-01-30T15:51:16.481Z] Test passed after 1 failed attempt on refactor/lodash-unescape-categories-block.
[2023-01-31T21:35:31.030Z] Test passed after 2 failed attempts on try/list-view-modify-shortcut-focus.
[2023-02-01T06:27:36.042Z] Test passed after 2 failed attempts on try/list-view-modify-shortcut-focus.
[2023-02-01T09:07:20.139Z] Test passed after 1 failed attempt on update/extracted-get-supported-styles.
[2023-02-01T10:10:42.699Z] Test passed after 1 failed attempt on update/get-last-selected-block-client-id-to-experimental.
[2023-02-01T13:27:51.062Z] Test passed after 1 failed attempt on rnmobile/bump-aztec-version-1.6.3.
[2023-02-01T16:19:22.565Z] Test passed after 1 failed attempt on fix/46469.
[2023-02-02T06:00:54.912Z] Test passed after 2 failed attempts on add/split-inspector-pointer.
[2023-02-02T10:06:41.518Z] Test passed after 1 failed attempt on add/block-types-prop-pattern-directory-controller.
[2023-02-02T10:07:37.593Z] Test passed after 1 failed attempt on fix/47022.
[2023-02-02T10:38:33.919Z] Test passed after 1 failed attempt on add/click-to-edit.
[2023-02-02T11:15:23.549Z] Test passed after 1 failed attempt on try/zoom-out-iframe-scale.
[2023-02-02T12:01:42.942Z] Test passed after 2 failed attempts on try/excerpt-length-setting.
[2023-02-02T12:13:20.500Z] Test passed after 1 failed attempt on try/footnotes-again.
[2023-02-02T13:15:22.907Z] Test passed after 1 failed attempt on try/rich-text-stable-on-focus.
[2023-02-02T15:12:50.920Z] Test passed after 1 failed attempt on add/settings-drawer-to-link-control.
[2023-02-02T15:39:41.792Z] Test passed after 1 failed attempt on try/zoom-out-iframe-scale.
[2023-02-02T15:43:24.977Z] Test passed after 1 failed attempt on try/rich-text-stable-on-focus.
[2023-02-02T16:29:27.397Z] Test passed after 1 failed attempt on try/shuffle-content-only-pattern.
[2023-02-02T16:52:37.411Z] Test passed after 1 failed attempt on trunk.
[2023-02-02T18:46:27.772Z] Test passed after 1 failed attempt on trunk.
[2023-02-02T21:50:19.027Z] Test passed after 1 failed attempt on update/combobox-control-ts.
[2023-02-02T23:17:30.970Z] Test passed after 1 failed attempt on update/combobox-control-ts.
[2023-02-02T23:28:43.079Z] Test passed after 1 failed attempt on trunk.
[2023-02-03T02:03:09.991Z] Test passed after 1 failed attempt on add/layout-tests.
[2023-02-03T09:06:05.948Z] Test passed after 1 failed attempt on rnmobile/add-visual-tests.
[2023-02-03T10:34:34.067Z] Test passed after 1 failed attempt on rnmobile/add-visual-tests.
[2023-02-03T13:53:01.410Z] Test passed after 1 failed attempt on rnmobile/add-visual-tests-failing-test.
[2023-02-03T14:55:45.987Z] Test passed after 1 failed attempt on add/settings-drawer-to-link-control.
[2023-02-03T15:14:54.012Z] Test passed after 1 failed attempt on fix/multi-entities-save-state.
[2023-02-04T10:06:17.804Z] Test passed after 1 failed attempt on quality/hide-empty-section.
[2023-02-06T02:19:57.446Z] Test passed after 1 failed attempt on update/privatise-__experimentalShowSelectedHint.
[2023-02-06T03:49:35.252Z] Test passed after 2 failed attempts on try/list-view-modify-shortcut-focus.
[2023-02-06T11:14:23.687Z] Test passed after 1 failed attempt on trunk.
[2023-02-06T20:28:07.487Z] Test passed after 1 failed attempt on trunk.
[2023-02-06T23:06:23.359Z] Test passed after 1 failed attempt on try/fix-toolspanel-on-paste-styles.
[2023-02-06T23:24:37.458Z] Test passed after 1 failed attempt on try/fix-toolspanel-on-paste-styles.
[2023-02-06T23:38:56.764Z] Test passed after 1 failed attempt on perf/avoid-cloning-in-event-emitter.
[2023-02-07T08:48:50.607Z] Test passed after 1 failed attempt on rnmobile/split-e2e-tests.
[2023-02-07T09:26:26.967Z] Test passed after 1 failed attempt on trunk.
[2023-02-07T11:19:41.238Z] Test passed after 1 failed attempt on try/nav-block-integration-test-experiment.
[2023-02-07T11:23:48.842Z] Test passed after 1 failed attempt on refactor/menu-items-choice-to-typescript.
[2023-02-07T12:57:31.304Z] Test passed after 2 failed attempts on update/dewp-dependency-json2php.
[2023-02-07T13:44:24.613Z] Test passed after 1 failed attempt on fix/append_to_selector.
[2023-02-07T14:46:30.690Z] Test passed after 1 failed attempt on rnmobile/split-e2e-tests.
[2023-02-07T16:35:23.370Z] Test passed after 2 failed attempts on update/dewp-dependency-json2php.
[2023-02-07T20:44:35.202Z] Test passed after 1 failed attempt on add/button-border-support.
[2023-02-07T23:11:52.152Z] Test passed after 1 failed attempt on tests/store-perf-test-results.
[2023-02-07T23:13:53.189Z] Test passed after 1 failed attempt on perf/run-another-branch-first.
[2023-02-08T00:39:03.438Z] Test passed after 1 failed attempt on add/aspect-ratio-featured-image.
[2023-02-08T08:47:39.175Z] Test passed after 1 failed attempt on trunk.
[2023-02-08T16:09:43.321Z] Test passed after 1 failed attempt on trunk.
[2023-02-09T08:57:25.047Z] Test passed after 1 failed attempt on refactor/remove-name-element-props-from-typography-panel.
[2023-02-09T09:01:09.685Z] Test passed after 1 failed attempt on trunk.
[2023-02-09T09:01:19.888Z] Test passed after 1 failed attempt on fix/autocomplete-iframe-a11y.
[2023-02-09T09:12:33.839Z] Test passed after 1 failed attempt on add/text-color-support-to-cover.
[2023-02-09T10:42:22.068Z] Test passed after 1 failed attempt on trunk.
[2023-02-09T12:34:15.967Z] Test passed after 1 failed attempt on wp/6.2.
[2023-02-09T14:01:56.811Z] Test passed after 1 failed attempt on add/tag-processor-bookmark-invalidation-logic.
[2023-02-09T14:51:01.974Z] Test passed after 1 failed attempt on update/eslint-react-hooks-exhaustive-deps.
[2023-02-09T19:29:11.077Z] Test passed after 1 failed attempt on trunk.
[2023-02-10T11:04:39.777Z] Test passed after 1 failed attempt on add/nested-template-level.
[2023-02-10T12:24:29.345Z] Test passed after 1 failed attempt on refactor/tools-panel-storybook-typescript.
[2023-02-10T12:48:25.048Z] Test passed after 1 failed attempt on add/navigation-warning-test.
[2023-02-10T12:57:26.474Z] Test passed after 1 failed attempt on add/create-fallback-navigation.
[2023-02-10T17:50:18.449Z] Test passed after 1 failed attempt on trunk.
[2023-02-11T00:42:24.853Z] Test passed after 1 failed attempt on perf/run-another-branch-first.
[2023-02-11T04:10:28.463Z] Test passed after 1 failed attempt on fix/link-control-scrollbar.
[2023-02-11T05:22:53.468Z] Test passed after 1 failed attempt on fix/block-iframe-border.
[2023-02-11T05:41:19.464Z] Test passed after 1 failed attempt on fix/block-iframe-border.
[2023-02-11T10:29:01.415Z] Test passed after 1 failed attempt on experiments-rename-export-to-private-apis.
[2023-02-13T02:11:56.660Z] Test passed after 1 failed attempt on fix/performancewp_render_layout_support_flag.
[2023-02-13T08:59:30.363Z] Test passed after 1 failed attempt on add/details-summary-block.
[2023-02-13T10:41:37.995Z] Test passed after 1 failed attempt on add/nested-template-level.
[2023-02-13T11:32:31.612Z] Test passed after 1 failed attempt on add/nested-template-level.
[2023-02-13T13:15:09.048Z] Test passed after 1 failed attempt on trunk.
[2023-02-13T14:07:51.284Z] Test passed after 1 failed attempt on add/create-fallback-navigation.
[2023-02-13T14:20:40.403Z] Test passed after 1 failed attempt on update/blocks-that-can-be-submenus.
[2023-02-13T15:23:04.622Z] Test passed after 1 failed attempt on migrate/playwright-query.
[2023-02-13T16:49:18.445Z] Test passed after 1 failed attempt on migrate/playwright-multi-block-selection.
[2023-02-13T21:59:47.218Z] Test passed after 1 failed attempt on fix/make-navigation-page-list-load-its-items-on-sidebar.
[2023-02-14T10:41:56.426Z] Test passed after 1 failed attempt on fix/performancewp_render_layout_support_flag.
[2023-02-14T11:20:02.068Z] Test passed after 1 failed attempt on trunk.
[2023-02-15T03:16:45.529Z] Test passed after 1 failed attempt on fix/global-styles-left-padding.
[2023-02-15T07:42:05.887Z] Test passed after 1 failed attempt on rnmobile/add-reassure.
[2023-02-15T08:07:18.033Z] Test passed after 1 failed attempt on enhancement/paragraph-top-heading-shortcut.
[2023-02-15T08:32:25.023Z] Test passed after 2 failed attempts on trunk.
[2023-02-15T08:33:56.260Z] Test passed after 1 failed attempt on enhancement/paragraph-top-heading-shortcut.
[2023-02-15T12:59:22.267Z] Test passed after 1 failed attempt on extract/dimensions-panel.
[2023-02-15T14:17:34.360Z] Test passed after 1 failed attempt on refactor/page-list-modal.
[2023-02-15T20:25:19.073Z] Test passed after 1 failed attempt on fix/autocomplete-iframe-a11y.
[2023-02-16T02:20:31.843Z] Test passed after 1 failed attempt on rnmobile/add-reassure.
[2023-02-16T02:41:24.824Z] Test passed after 1 failed attempt on trunk.
[2023-02-16T06:40:06.702Z] Test passed after 1 failed attempt on form-fields.
[2023-02-16T09:13:42.816Z] Test passed after 1 failed attempt on test/stabilize-perf-tests.
[2023-02-16T14:09:03.547Z] Test passed after 1 failed attempt on fix/i18n-strings.
[2023-02-16T21:10:10.462Z] Test passed after 1 failed attempt on annezazu-versions-update-6-2.
[2023-02-17T06:08:06.826Z] Test passed after 1 failed attempt on add/details-summary-block.
[2023-02-17T09:40:41.593Z] Test passed after 1 failed attempt on fix-i18n/block-mobile-toolbar.
[2023-02-17T10:03:09.873Z] Test passed after 2 failed attempts on fix/selection-on-replace.
[2023-02-17T10:05:28.722Z] Test passed after 1 failed attempt on fix-i18n/block-editor-hooks.
[2023-02-17T11:32:16.377Z] Test passed after 1 failed attempt on fix/changing-deps.
[2023-02-17T12:18:24.339Z] Test passed after 2 failed attempts on fix/site-editor-performance-tests.
[2023-02-17T12:22:21.226Z] Test passed after 1 failed attempt on fix-i18n/block-mobile-toolbar.
[2023-02-17T12:39:59.812Z] Test passed after 1 failed attempt on fix-i18n/block-editor-hooks.
[2023-02-17T12:57:46.627Z] Test passed after 1 failed attempt on fix-i18n/block-switcher.
[2023-02-17T12:59:39.212Z] Test passed after 1 failed attempt on fix-i18n/block-settings.
[2023-02-17T14:39:39.472Z] Test passed after 1 failed attempt on fix/align-block-remount.
[2023-02-17T16:38:05.080Z] Test passed after 1 failed attempt on fix/offcanvaseditor-does-not-insert-submenu-on-collapsed-items.
[2023-02-20T14:35:46.391Z] Test passed after 1 failed attempt on add/html-tag-processor-wp-6-3-compat-layer.
[2023-02-20T17:09:29.328Z] Test passed after 1 failed attempt on wp/6.2.
[2023-02-20T23:07:14.491Z] Test passed after 1 failed attempt on fix/site-editor-perf-tests.
[2023-02-21T02:00:06.257Z] Test passed after 1 failed attempt on 44340-themes-provide-more-resources-to-clarify-what-can-be-done-in-themejson-vs-styles-interface.
[2023-02-21T02:41:14.168Z] Test passed after 1 failed attempt on fix/site-editor-perf-tests.
[2023-02-21T03:17:46.583Z] Test passed after 1 failed attempt on fix/site-editor-perf-tests.
[2023-02-21T04:57:59.356Z] Test passed after 1 failed attempt on fix/edit-widgets-move-block.
[2023-02-21T05:38:16.775Z] Test passed after 1 failed attempt on add/details-summary-block.
[2023-02-21T06:31:37.012Z] Test passed after 1 failed attempt on trunk.
[2023-02-21T07:37:04.418Z] Test passed after 1 failed attempt on improve/get-block-parents-empty.
[2023-02-21T08:06:18.882Z] Test passed after 1 failed attempt on improve/get-block-parents-empty.
[2023-02-21T08:16:47.961Z] Test passed after 1 failed attempt on trunk.
[2023-02-21T08:20:42.570Z] Test passed after 1 failed attempt on perf/type-200-times-instead-of-20.
[2023-02-21T08:40:36.118Z] Test passed after 1 failed attempt on trunk.
[2023-02-21T12:45:32.185Z] Test passed after 1 failed attempt on fix/site-editor-performance-tests.
[2023-02-21T16:12:53.594Z] Test passed after 2 failed attempts on track/lcp-minus-ttfb.
[2023-02-22T04:59:05.530Z] Test passed after 1 failed attempt on add/site-tagline-to-style-book.
[2023-02-22T15:50:02.580Z] Test passed after 1 failed attempt on gs-support-duotone.
[2023-02-22T16:35:21.105Z] Test passed after 1 failed attempt on try/autocomplete-perf.
[2023-02-22T17:09:00.099Z] Test passed after 1 failed attempt on add/post-terms-variations-transforms.
[2023-02-22T18:04:51.558Z] Test passed after 1 failed attempt on annezazu-versions-update-6-2.
[2023-02-23T01:33:10.545Z] Test passed after 1 failed attempt on 44340-themes-provide-more-resources-to-clarify-what-can-be-done-in-themejson-vs-styles-interface.
[2023-02-23T04:05:22.608Z] Test passed after 1 failed attempt on update/page-attributes-check-selector.
[2023-02-23T07:28:01.182Z] Test passed after 1 failed attempt on trunk.
[2023-02-23T08:58:41.971Z] Test passed after 1 failed attempt on trunk.
[2023-02-23T10:06:25.448Z] Test passed after 1 failed attempt on try/use-duotone-presets-for-blocks.
[2023-02-23T11:52:30.325Z] Test passed after 1 failed attempt on trunk.
[2023-02-23T12:36:42.021Z] Test passed after 1 failed attempt on revert/link-control-changes.
[2023-02-23T14:32:45.480Z] Test passed after 1 failed attempt on trunk.
[2023-02-23T17:33:03.963Z] Test passed after 1 failed attempt on rnmobile/add-spacer-presets-support.
[2023-02-23T18:27:09.086Z] Test passed after 1 failed attempt on update/output-duotone-presets-per-block.
[2023-02-23T20:15:26.518Z] Test passed after 1 failed attempt on trunk.
[2023-02-24T00:30:03.108Z] Test passed after 1 failed attempt on feat/storybook-e2e-tests-custom-controls.
[2023-02-24T03:55:27.228Z] Test passed after 1 failed attempt on refactor/tabpanel-unit-tests.
[2023-02-24T06:24:11.215Z] Test passed after 1 failed attempt on fix/widget-importer-empty-state.
[2023-02-24T07:18:04.575Z] Test passed after 1 failed attempt on wp/6.2.
[2023-02-24T08:25:11.465Z] Test passed after 1 failed attempt on try/featured-image-caption.
[2023-02-27T15:13:52.705Z] Test passed after 1 failed attempt on release/15.2.
[2023-02-28T15:43:10.998Z] Test passed after 1 failed attempt on wp/6.2.
[2023-02-28T16:02:33.704Z] Test passed after 1 failed attempt on wp/6.2.
[2023-02-28T23:03:18.793Z] Test passed after 1 failed attempt on release/15.2.
[2023-03-01T06:09:18.902Z] Test passed after 1 failed attempt on wp/6.2.
[2023-11-14T21:27:58.004Z] Test passed after 1 failed attempt on experiment/show-styles-inherited-values.
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Array [
    Object {
      "attributes": Object {
-       "content": "1|2",
+       "content": ".|]2",
        "level": 2,
      },
      "name": "core/heading",
    },
  ]

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/multi-block-selection.spec.js:1061:3
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label Sep 22, 2022
@github-actions
Copy link
Author

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Oct 23, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2022
@github-actions github-actions bot reopened this Dec 16, 2022
@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Dec 17, 2022
github-actions bot referenced this issue Dec 22, 2022
Tests are broken because the attribute sourcer needs rework given this
different approach for navigating tags.
github-actions bot referenced this issue Dec 22, 2022
* BorderControl: improve popover waiting

* Remove async where there's no await

* Enable real timers manually
github-actions bot referenced this issue Dec 29, 2022
…beginning, after, before and to the end of the content.
github-actions bot referenced this issue Jan 4, 2023
…#46875)

* Block Inspector: fix browser warning error when block is not selected

* Update changelog
github-actions bot referenced this issue Jan 4, 2023
github-actions bot referenced this issue Jan 13, 2023
…les (#47103)

* Block Editor: Move component styles needed for iframes to content styles

* Update Changelog
github-actions bot referenced this issue Feb 23, 2023
…47834)

* adds all allowed innerblocks to the inspector animation experiment

* don't animate unless we're in a navigation block

* make the nav block a config

* Update packages/block-editor/src/components/block-inspector/index.js

Co-authored-by: Andrei Draganescu <[email protected]>

* remove redundant comment

* be more clear block animation is temporary

---------

Co-authored-by: scruffian <[email protected]>
github-actions bot referenced this issue Feb 23, 2023
* Naive implementation

* Refactor to named functions

* Fix order of hooks

* Utilise existing duotone presets on front of site

* Improve self documenting code

* Refactor away redundant color prop of filter_preset

* Satisfy master yoda…

* More commenting

* Remove count() check for duotone color array

Duotone color arrays can be more than 2 colors, and the code doesn't seem to handle 2 colors differently than 3 or more, so the count() === 2 was unnecessary. Since we've already defined the $is_duotone_colors_array, we can use it later instead of redoing another is_array() check.

* Improve comments and linting

* Allow Duotone to be cleared using UI

* Add initial tests for getColorsFromDuotonePreset

* Be explicit about handling presets vs colors

Previously the decision about how to handle values were deferred to the utility. Instead the consuming code should decide whether to look for a preset.

* Complete tests for getColorsFromDuotonePreset

* Add tests and fix implementation of getDuotonePresetFromColors

* Fix bug with selecting custom colors introduced during test refactor

* Fix custom colors Duotone on front end rendering

---------

Co-authored-by: Jerry Jones <[email protected]>
github-actions bot referenced this issue Feb 23, 2023
* Fixed incorrect type ordering in @wordpress/data type annotations

* Fixed incorrect variable types preventing declaration merging

* Removed unneeded @type annotations
github-actions bot referenced this issue Feb 24, 2023
* Revert "Move Link Control action buttons into lower area (#47309)"

This reverts commit e605937.

* Revert "Fix Link Control action button visuals (#47306)"

This reverts commit 2499646.

* Revert "Add clear Apply and Cancel buttons to Link Control (#46933)"

This reverts commit 875628f.

# Conflicts:
#	packages/block-editor/src/components/link-control/index.js
@github-actions github-actions bot reopened this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant