-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate query test to Playwright #47995
Conversation
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
Flaky tests detected in d65d318. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4164730243
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment. Otherwise, it looks great! Thanks! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
ab50bef
to
d65d318
Compare
What and why?
Part of #38851. Hopefully fixes #47632. Based on #43763 by @pavanpatil1.
How?
Judging from the failure artifacts in #47632, it seems like the test sometimes fails to select the correct query pattern. This could be related to layout shifting in the modal. Playwright automatically checks for actionability when clicking, so hopefully migrating it to Playwright fixes the issue.
Testing Instructions
CI should pass.