Performance: Fix empty results handling in performance test results #47646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 1bb768e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4064323730
|
youknowriad
approved these changes
Feb 1, 2023
|
I'm not sure it fixed it? I don't see this branch reported |
|
Nope, unfortunately it didn't. But I have another fix coming in a second. |
|
Here's the fix: #47650. Seems like we inadvertently removed the reduce initial value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR is adding handling for non-objects in the performance test results logger script.
Why?
I think we broke the performance results with #47600. I believe this PR should fix them.
How?
We're adding a fallback to an empty object to handle the case of no performance results for the specified hash.
Testing Instructions
Similar to #47442 😅