Log frontend perf results in codehealth #47442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 4c0a3ae. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4014107005
|
oandregal
reviewed
Jan 26, 2023
| 'utf8' | ||
| const resultsFiles = [ | ||
| { | ||
| file: 'post-editor-performance-results.json', |
There was a problem hiding this comment.
I was trying to run this locally. I commented the parts that were about making the request to codehealth. Then, what I did was running the performance test and move the generated files to where this command expects them to be. For example, for post editor:
npm run test:performance -- --puppeteer-interactive packages/e2e-tests/specs/performance/post-editor.test.jscp packages/e2e-tests/specs/performance/post-editor.test.results.json post-editor-performance-results.json
And similarly for the other two. Note that I had to rename the file, so I wonder if I missed another command? I guess my question is: are these paths expected?
Other than that, the command reported numbers, so it seems fine.
There was a problem hiding this comment.
yeah, you need to run the comparison command ./bin/plugin/cli.js perf branch1 branch2 to get the right files.
oandregal
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Left a comment about the paths https://github.com/WordPress/gutenberg/pull/47442/files#r1087679545 but other than that it seems fine.
10 tasks
tyxla
reviewed
Jan 30, 2023
There was a problem hiding this comment.
@youknowriad considering that we already removed all instances of mapKeys() in the repository, WDYT about replacing _.mapKeys() with Object.entries().map()?
|
@tyxla sure, this is a tool though so there's no bundle size issue or anything. It would be good to start adding some lint errors whenever we get rid of some import. |
Sure, I realize that but ideally our end goal is to get rid of it entirely from the repo, otherwise, it can quickly be reintroduced if it sticks as a dependency.
We're already doing that, but for CommonJS ( |
|
Alternatively, for CJS we could start importing from specific modules (e.g. |
This was referenced Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #47037 some frontend performance metrics have been added to our performance job. This PR logs the results in code health so we can track them over time.
I've did some manual tests locally, but we won't be able to test this 100% until we merge it :)