-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @storybook/addon-knobs from the repository #47152
Conversation
Size Change: +266 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
Flaky tests detected in 7184657. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3939754357
|
I'm refraining from a review while this is a draft, but please feel free to re-request one once this is ready, @ciampo. |
9deb67a
to
39c0f08
Compare
All knobs usages should have been migrated. Time to give this PR a review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @ciampo 🚀
Tests well for me and code looks great
Co-authored-by: Marin Atanasov <[email protected]>
Thank you! I applied your change, will merge as soon as CI is ✅ |
What?
Remove the
@storybook/addon-knobs
dependency from the repositoryWhy?
The dependency has been deprecated for a long time, and we recently removed all usages from all Storybook examples.
This dependency is currently blocking using npm 8 (see #46443)
How?
Removed from:
Testing Instructions
trunk
trunk