-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook: Migrate Knobs to Controls #35665
Labels
[Feature] UI Components
Impacts or related to the UI component system
Needs Dev Note
Requires a developer note for a major WordPress release cycle
[Package] Components
/packages/components
Storybook
Storybook and its stories for components
[Type] Tracking Issue
Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Comments
mirka
added
[Feature] UI Components
Impacts or related to the UI component system
Storybook
Storybook and its stories for components
labels
Oct 15, 2021
This was referenced Oct 15, 2021
This was referenced Feb 11, 2022
ciampo
added
[Type] Tracking Issue
Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
[Package] Components
/packages/components
labels
Feb 16, 2022
This was referenced Apr 29, 2022
This was referenced Aug 16, 2022
This was referenced Dec 13, 2022
This was referenced Dec 23, 2022
This was referenced Jan 7, 2023
bph
added
the
Needs Dev Note
Requires a developer note for a major WordPress release cycle
label
Jan 14, 2023
Added the "Needs Dev Note" label to put in our our radar for WordPress 6.2 Fieldguide
At the moment if seems like a stand-along post would be warranted. |
Migration complete 🎉 Addon package removed in #47152. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] UI Components
Impacts or related to the UI component system
Needs Dev Note
Requires a developer note for a major WordPress release cycle
[Package] Components
/packages/components
Storybook
Storybook and its stories for components
[Type] Tracking Issue
Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
What problem does this address?
New stories should be written using Controls, as this will make things much easier and Knobs are now deprecated.
Because Controls and Knobs are shown in separate panels, to have them both enabled globally is noisy and confusing. It also encourages people to continue using Knobs in new stories.
What is your proposed solution?
It would probably be better if we migrated the existing Knobs usage to Controls, and remove the global Knobs decorator. For the few stories that would be less than straightforward to migrate at this time, we can keep them as is and add the Knobs decorator for those isolated cases.
The text was updated successfully, but these errors were encountered: