-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WP_HTML_Tag_Processor: Rename attribute_updates to lexical_updates #47053
Conversation
Flaky tests detected in b24d6c7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3930915630
|
c7eba79
to
7f84941
Compare
7f84941
to
b24d6c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it helps then I think we can merge this now as a rename and consider the deeper implications as we go. At least, this is an easy change to review. Thanks 👍
What?
Rename:
$attribute_updates
member to$lexical_updates
apply_attribute_updates()
toapply_lexical_updated()
class_name_updates_to_attributes_updates()
toclass_name_updates_to_lexical_updates
And update PHPDoc and comments accordingly.
All of these are
private
, so we're not breaking any APIs.Why?
To enable other kinds of updates via the same mechanism, e.g. for a prospective
set_content_inside_balanced_tags()
. See #47036 and #46680 (comment) for more context.How?
It's a simple rename 😬
Testing Instructions
See unit tests.