Ensure replacing a template part using a pattern doesn't update the existing entity #44221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: -28 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
glendaviesnz
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
This tested well for me. I see that replacing the template blocks when selecting a pattern was a deliberate design decision initially (here and here), but as you note it seems like this approach makes more sense, because the current approach could result in the inadvertent overwriting of template content in templates that are used in multiple places.
talldan
deleted the
fix/template-part-replace-removing-existing-blocks
branch
|
I just cherry-picked this PR to the wp/6.1 branch to get it included in the next release: 69597b9 |
ockham
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the comment here - #41397 (comment), see also #44147
Why?
As mentioned in the above issue comment, it can be confusing that selecting a template part creates a new entity, while selecting a pattern replaces the blocks in the existing entity.
This can also be destructive if the user didn't intend to update the entity. A template part can be used across multiple templates, so it would result in unexpectedly widespread changes.
How?
Remarkably the fix is to delete some code. There was a specific code path added to replace the template part's blocks, but I removed this in favour of the same behavior the template part's placeholder has - creating a new entity and setting that entity as active.
Testing Instructions
Screenshots or screencast
Before
Kapture.2022-09-16.at.16.23.41.mp4
After
Kapture.2022-09-16.at.16.21.07.mp4