Storybook: Support dashicons for testing #43721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
t-hamano
approved these changes
Aug 31, 2022
mirka
force-pushed
the
storybook-dashicon
branch
from
0431c40
to
a7f218d
Compare
|
Interesting PR! Some time ago I worked on removing all dashicon usages from Storybook, since dashicons are apparently "unofficially deprecated" (as Riad mentioned). The idea behind that PR is that we could start the deprecation by stopping to use I see that @mirka also opened #43725, so I wonder — what is the short term plan, and the long term plan? Is it a good idea to add |
It's still questionable whether we can actually deprecate dashicons, and since we are getting active bug reports (#43574) related to their use, I think we need to be supporting (i.e. testing) them in the meantime. In any case I think we should start by updating our docs, even if we can't formally deprecate. A number of them (e.g. Icon, DropdownMenu) still prominently mention dashicons. gutenberg/packages/components/src/dropdown-menu/README.md Lines 135 to 137 in b4417e9 |
|
Sounds good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43700
What?
Adds the dashicons stylesheet to the "WordPress" preset in the Global CSS Injector.
Why?
Some components need to support dashicons for backward compatibility. We should be able to test that in Storybook.
Testing Instructions
npm run storybook:devScreen Recording
CleanShot.2022-08-31.at.03.33.08.mp4