Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook: Dashicons cannot be tested #43700

Closed
mirka opened this issue Aug 30, 2022 · 0 comments · Fixed by #43721
Closed

Storybook: Dashicons cannot be tested #43700

mirka opened this issue Aug 30, 2022 · 0 comments · Fixed by #43721
Assignees
@mirka
Labels
Storybook Storybook and its stories for components

Comments

@mirka
Copy link
Member

mirka commented Aug 30, 2022

What problem does this address?

We cannot test Dashicon rendering in Storybook because the webfont and stylesheet is not loaded. Components still need to support Dashicons for backwards compatibility.

What is your proposed solution?

Load the font and stylesheet as part of the Global CSS add-on's "WordPress" preset.
@mirka mirka added the Storybook Storybook and its stories for components label Aug 30, 2022
@mirka mirka mentioned this issue Aug 30, 2022
Merged
@mirka mirka self-assigned this Aug 30, 2022
@mirka mirka mentioned this issue Aug 30, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 30, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirka mirka

Labels
Storybook Storybook and its stories for components
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Storybook: Support dashicons for testing WordPress/gutenberg
2 participants
@mirka @priethor