Image: Restore baseline responsiveness in the block. #39340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
Size Change: +9 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
MaggieCabrera
approved these changes
Mar 10, 2022
mikachan
reviewed
Mar 10, 2022
|
Thanks all! Going to land it. |
|
@jasmussen, should we backport this fix as well into a minor release? I'm backporting #39045. |
|
@Mamaduka If we were to backport it, I'd feel it a pretty safe one to backport, so it would be nice, yes. But probably also not crucial. |
|
Since this is a small one, I also feel it's safe to backport, so let's ship with this minor release 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Followup to #38399 and feedback in #39045 (comment). While the new responsive rules from 39045 work for images inserted, they don't work for images in patterns. As a result, you might see this cropped bird in the Patterns tab:
This PR restores the image specific rule, fixing it:
The basic responsive rule is still kept intact, as it still serves a purpose for targetting images inserted in the classic editor.
Testing Instructions
Test the pattern library of TwentyTwentyTwo before and after this PR, and observe the "Wide image" pattern scaling its image properly.