Archeo: fix image block widths #5634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
those IDs won't work on all sites if they already have images installed with that ID. Joen said that he was going to make a PR to fix the issue, I think we can patch with CSS instead of changing the markup while the fix makes it to GB |
|
Ah OK, I was wondering about the IDs. Thanks! I'll change this PR to a patch then. |
|
I've added a CSS patch for all Image Block images, using this selector: |
|
WordPress/gutenberg#39340 will fix the image issue and when that makes it to dotcom we can remove the CSS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This adds the
wp-image-class and ID attribute to any image blocks in Archeo's patterns.Since WordPress/gutenberg#39045 was merged, only images that have the
wp-image-class are targeted with the responsive styles. Without this class, the images are not resized to 100%:It looks like images in cover blocks and media + text blocks are not affected.
Do we need to run through all block themes and add these classes?