Experiment: "Live block" using the latest-comments block #38843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalczaplinski
requested review from
TimothyBJacobs,
spacedmonkey and
ajitbohra
as code owners
|
Size Change: +229 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
michalczaplinski
removed request for
spacedmonkey,
ajitbohra and
TimothyBJacobs
michalczaplinski
added
[Feature] Blocks
|
I'm so glad you are exploring this approach. It made me realize that the To give an example let's use the Comment Content block. It reads the comment id from the block context: gutenberg/packages/block-library/src/comment-content/index.php Lines 16 to 19 in b22ce95 I checked the existing core blocks that use the gutenberg/packages/block-library/src/calendar/edit.js Lines 89 to 92 in b22ce95 gutenberg/packages/block-library/src/calendar/index.php Lines 27 to 41 in b22ce95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment in "server components" pattern. It's related to the #38713 as this PR is using the same pattern of data loading +
morphdom.Here, I have created a new block called
latest-comments-filterwhich dynamically loads the HTML for thelatest-commentsblock from the props passed to theblock-rendererendpoint. It then usesmorphdomto update thelatest-commentsblock's DOM with new HTML.Some video demos (there is some vague speculation at the end of the first video, sorry for that 😅)
2022-02-15_19-22-27.mp4
I've forgotten to mention some additional stuff so short part 2:
2022-02-15_19-42-23.mp4