-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment: Client-side navigation with pagination block and query loop. #38713
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Override the default click handler of the pagination-next anchor - Load the HTML for the new page with Fetch instead - Use morphdom library to merge new HTML into the current page Co-authored-by: Luis Herranz <[email protected]>
Size Change: +27 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
gziolo
added
[Type] Technical Prototype
Offers a technical exploration into an idea as an example of what's possible
[Feature] Blocks
Overall functionality of blocks
labels
Feb 11, 2022
This was referenced Sep 9, 2022
If I understand correctly, it seems that the client-side pagination is already implemented by #53812. I'd like to close this PR, but if I've missed anything, please feel free to reopen it at any time. cc: @luisherranz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Blocks
Overall functionality of blocks
[Type] Technical Prototype
Offers a technical exploration into an idea as an example of what's possible
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment with the Pagination and Query Loop blocks.
Modified the
Pagination Next
block to load the new HTML from the server Turbolinks-style and merge the new HTML into the current page without a full page reload.You can check the code, it's barely 30 lines but the steps are roughly:
view.js
file of thePagination Next
blockhistory.pushState()
Still a bit buggy, but you get the idea:
Screen.Recording.2022-02-10.at.13.40.36.mov