Remove navigation panel in site editor #36194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Feature] Template Editing Mode
|
Size Change: -3.91 kB (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
|
This completely removes all template previews, or is there a way to preview them that I have not considered? |
|
Fixed as I was typing :) |
|
maybe it would feel less awkward if the full screen mode was optional like in the block editor. |
What do you mean by "template previews"?
Yeah, makes sense. I'd treat this as a temporary solution until we implement the new design. |
|
The type of preview that was available in the navigation sidebar when you hovered over a template:
|
|
I see. I don't think that's available anymore in this design though. c.c. @jameskoster for additional details. |
kevin940726
force-pushed
the
add/simplified-template-list
branch
from
85a09a6
to
7f759f0
Compare
kevin940726
requested review from
ajitbohra,
nerrad,
ntwb,
spacedmonkey and
TimothyBJacobs
as code owners
|
Correct, the designs in #29630 dictate that holistic template management is handled via Appearance > Templates, and this "Editor (beta)" focuses purely on the site homepage. |
jameskoster
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
This works well. There's a question around whether the W button should take you back to the screen you were on previously, or always to the Dashboard. And related to that whether we might add a hover effect indicating what will happen on click.
But we can probably address that separately.
Edit: The Styles link feels a bit weird to me – mostly because I'm not sure what to do when I land in the editor. The welcome guides will hopefully help with that.
This was referenced Nov 4, 2021
carolinan
added
[Feature] Site Editor
7 tasks
This was referenced Nov 9, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the design in #29630 (comment).
Remove the "W" navigation panel in the site editor, and add a "Styles" link in "Appearance".
<NavigationSidebar>is not being referenced anymore and should be shaken off the bundle, but the code is still there in case when we want to implement the design in #29630 (comment). We could delete all the code too though, I couldn't decide.The "Styles" link is done with a hacky style, I wonder if there's a best practice for this?
Note that currently there's no way to go to other templates though, that's related to #35990 and #35994.
How has this been tested?
/wp-adminthemes.php?page=gutenberg-edit-site&styles=openScreenshots
Kapture.2021-11-04.at.13.04.32.mp4
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).