Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSE beta: remove W toggle override code #57834

Closed
vindl opened this issue Nov 9, 2021 · 1 comment
Closed

FSE beta: remove W toggle override code #57834

vindl opened this issue Nov 9, 2021 · 1 comment
Assignees
@mattwiebe
Labels
[Goal] Full Site Editing

Comments

@vindl
Copy link
Member

vindl commented Nov 9, 2021

After the removal of the browsing sidebar in core (WordPress/gutenberg#36194) we no longer need to override the behavior of this button. We should spin up a janitorial PR to clean up our custom code.
@Addison-Stavlo Addison-Stavlo mentioned this issue Feb 22, 2022
Merged
@Addison-Stavlo
Copy link
Contributor

I opened a quick PR for this. @zaguiini noted the override is working again with the latest changes in Gutenberg trunk, so it seems more important to get rid of this code before that change makes its way to dotcom.

#61368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattwiebe mattwiebe

Labels
[Goal] Full Site Editing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattwiebe @vindl @Addison-Stavlo