Move and rename the site editor menu item #36064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
carolinan
added
[Feature] Full Site Editing
[Type] Enhancement
Replace toplevel_page_ with appearance_page_, remove menu order filter.
|
Size Change: -11 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
|
This moves the site editor from |
kevin940726
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
LGTM 👍
I don't think this closes #29630 though? There still seems to have some follow-ups to do. (We can open separate issues for them though)
Mamaduka
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Thanks for working on this, @carolinan.
This moves the site editor from admin.php?page=gutenberg-edit-site to themes.php?page=gutenberg-edit-site
I am not sure what backwards compatibility issues this may cause for plugins and that is why I am not convinced that this is the best way.
The Site Editor probably will have its custom file, like themes.php, when it's gets merged in the core.
P.S. The "Editor" and "Theme Editor" side by side might be a little confusing for users. Should we remove it for Block Themes?
Correct, it will end up in |
I also think it can be confusing, and there may be many simple miss clicks - but I don't want the feature removed. Perhaps moved. |
mattwiebe
added a commit
to Automattic/wp-calypso
that referenced
this pull request
Jan 25, 2022
`gutenberg_menu_order` was deleted in the 11.9 release: WordPress/gutenberg#36064
mattwiebe
added a commit
to Automattic/wp-calypso
that referenced
this pull request
Jan 25, 2022
`gutenberg_menu_order` was deleted in the 11.9 release: WordPress/gutenberg#36064
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the site editor menu item to Appearance and change the label to Editor
For #29630
How has this been tested?
Open the WordPress admin area and locate the menu item.
Screenshots
(Yes, this screenshot also include the plugin Theme Check under the Appearance menu)
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).