Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Site Editing: delete gutenberg_menu_order references #60462

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

mattwiebe
Copy link
Contributor

@mattwiebe mattwiebe commented Jan 25, 2022

Changes proposed in this Pull Request

Testing instructions

This should fix google/site-kit-wp#4485

Otherwise it should keep working as expected

Fixes #58971

`gutenberg_menu_order` was deleted in the 11.9 release: WordPress/gutenberg#36064
@mattwiebe mattwiebe requested a review from a team January 25, 2022 18:24
@mattwiebe mattwiebe self-assigned this Jan 25, 2022
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 25, 2022
@github-actions
Copy link

github-actions bot commented Jan 25, 2022

@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit update/universal-themes-compat on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@Addison-Stavlo Addison-Stavlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me.

Tested a simple site - no observable changes.

Tested self hosted with ETK and google Site Kit and this change allows them to 'play nice' and removes the fatal error.

@mattwiebe mattwiebe merged commit e7e9739 into trunk Jan 25, 2022
@mattwiebe mattwiebe deleted the update/universal-themes-compat branch January 25, 2022 19:20
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants