Try blue block chip in select mode and when dragging #31278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
General Interface
|
Size Change: +10 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Interesting exploration, I think my problem with making this blue is it seems to make it 'go somewhere' as looks now like a button. I think that might be an indication our use of color needs an audit though. |
|
In some respects it is a button, just one that invokes dragging/dropping, rather than a traditional button that navigates you to a separate screen. |
|
I do follow the line of thinking, but for this specific change I'm not sure it's working. Perhaps it's the WordPress blue showing its age, because it looks much better in the video in #31284. But as just a color change I don't think it's better than the black one, and probably premature to make such a change. This sort of echoes Tammie above, though I do think the blue could potentially work, exactly because it is more of an "interactive" color, and I think your explorations in #31283 support that. But it also opens up a bit of the question of what role select mode could play — if it was default in the site editor, for example, would it include the mover controls, and if that was the case, does the entire chip when blue look too interactive? That is to say — this might be a PR to rest on, noodle on, and come back to. |
It's a good question. Already Select mode is doing more than just enabling selection, since blocks can also be rearranged with drag and drop. I feel as though that is a good foundation though, and aligns with traditional design software where selecting and moving layers are behaviours that are closely linked. Editing is normally one layer abstracted, whether that is via a double click for things like text, or a separate panel / toolbar for things like colors. We may eventually need to come up with a different name that takes all of this in to account, but that's probably a discussion for another issue :D
I think that is the key here. And it's tricky to get a handle on how all the interactive elements play together in the scope of a single PR. I think you're right that we need to sit on this for a bit, and evaluate it in the context of the other Select mode changes we're considering (#31236). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally block interaction styles are treated with blue accents, for example:
This PR extends that heuristic to the block chip that appears when dragging a block (either from the inserter, or using the drag handle on the canvas), and when selecting a block in select mode.
Before
After
drag.mp4