Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing select mode #31236

Closed
2 of 10 tasks
jameskoster opened this issue Apr 27, 2021 · 8 comments
Closed
2 of 10 tasks

Enhancing select mode #31236

jameskoster opened this issue Apr 27, 2021 · 8 comments
Labels
Needs Design Needs design efforts. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Apr 27, 2021

In the Site Editor we've made a number of enhancements to the interactions around block selection. In particular indicating block outlines on hover / focus, aligning those styles with the new persistent list view, and indicating the parent container of the selected block on the canvas. We're also experimenting with click-through patterns (#30156 #31109) for containers like Reusable Blocks and Template Parts. So far these enhancements have been made to Edit mode in the Site Editor exclusively.

Some of these interactions already exist in one form or another in Select mode. So it may soon be time to think about aligning Edit mode in the Site editor with Select mode everywhere else. With alignment and consistent mode behaviour across editors we can then consider making Select the default mode in the Site Editor, where nested blocks and complex layouts are more common.

Here's what we can take from the work we've done so far in the Site Editor, and apply to Select mode holistically:

And here are some other enhancement ideas to explore:

And some 🐛 to squash:

Figma file to explore issues that need design here.

@jameskoster jameskoster added Needs Design Needs design efforts. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. labels Apr 27, 2021
@mtias
Copy link
Member

mtias commented Apr 27, 2021

Indicate the selected blocks container, if it has one

I am not totally sure about this one, I've found it mostly confusing in the site editor and it starts to diminish the clarity of the currently selected item. I think it can make sense for template part containers, but given the work to have overlays and isolated views it might not be necessary anymore.

@jameskoster
Copy link
Contributor Author

Yes, I think the parent outline style should be tied to the click-through UI.

That is to say: the parent outline should only be applied in situations where the click-through itself is utilised. And of course only if the click-through UI itself makes use of a parent outline style.

@mariohamann
Copy link

Hey @jameskoster , interesting to see your thoughts – I created very similar issues some months ago with analysis, examples and screenshots – maybe it is of any help for you:

#24751

Feel free to ask (GitHub or DM) if I can help you in any way to bring things forward!

@mrfoxtalbot
Copy link

Important: Implement an intuitive way to re-engage select mode from edit mode (the current esc pattern is not obvious)

At the moment the esc button only works one way. It enables select mode but will not bring you back to edit mode if you click on it a second time.

Toggling between the two modes would be easier if we could just press esc to do so.

@jameskoster
Copy link
Contributor Author

While a toggle could be a helpful secondary affordance, I wonder if the most intuitive heuristic would be to simply re-engage select mode whenever no block is actively selected.

We may also need to be careful about toggling modes on a single key, as it may be that there are more than two modes in the future. Dedicated shortcuts for each mode might be more scalable.

@jasmussen
Copy link
Contributor

I wonder if the most intuitive heuristic would be to simply re-engage select mode whenever no block is actively selected.

This could work, and it would allow us to let an additional Escape deselect all blocks something that in many apps is tied to that key already.

@mtias
Copy link
Member

mtias commented May 23, 2022

Is this issue still useful for tracking improvements?

@jameskoster
Copy link
Contributor Author

Probably not. Many things have changed since this issue was opened, which brings a few of the items into question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Needs design efforts. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

No branches or pull requests

5 participants