Use a modal for the template part creation flow #29108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Full Site Editing
[Type] Experimental
|
Size Change: +1.36 kB (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Feb 18, 2021
mtias
approved these changes
Feb 18, 2021
|
@jameskoster I think we should add a task to include the template area assignment in this step as well. Either in the same dialog or as two steps (showing the icons for the different template areas like header, footer, general). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #29040
This PR uses the same flow for template part creation as the one used for reusable blocks.
This new reusable block creation flow has three advantages: