Use a modal for the reusable blocks creation flow #29040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
youknowriad
added
[Feature] Synced Patterns
|
Size Change: +1.19 kB (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
One issue I'm seeing:
|
|
Good catch @mtias it should be fixed |
mtias
reviewed
Feb 17, 2021
| } } | ||
| > | ||
| <TextControl | ||
| label={ __( 'Name your reusable block' ) } |
There was a problem hiding this comment.
This could be just "Add name" or "Name"
There was a problem hiding this comment.
Sure, I just used what was shown on the issue's video :)
It is not as the PR currently stands: createtp.mp4But I think it would be good to keep these flows consistent. |
Agreed, the idea is that this PR is focused on the reusable block UI. Once it lands, the same flow will be applied to the template part as well. It's better to keep PRs small and focused to ease reviews... |
youknowriad
changed the title
|
Not directly related to this PR but noticed while looking at some string changes here. Language for reusable blocks feels a bit inconsistent. How about:
— or maybe better with lowerkey r, "reusable block"? As long as it's consistent. |
ntsekouras
approved these changes
Feb 18, 2021
| @@ -260,7 +235,7 @@ describe( 'Reusable blocks', () => { | |||
| // Save the reusable block | |||
| await page.click( publishButtonSelector ); | |||
| await page.waitForXPath( | |||
| '//*[contains(@class, "components-snackbar")]/*[text()="Reusable Block updated."]' | |||
| '//*[contains(@class, "components-snackbar")]/*[text()="Reusable block updated."]' | |||
There was a problem hiding this comment.
This breaks due to this: https://github.com/WordPress/gutenberg/blob/master/lib/compat.php#L266
Since we make blocks with a lower b, should we change the other Labels as well?
There was a problem hiding this comment.
It seems there's an inconsistency between Core and Gutenberg. Core menus favor capitalizing everything and Gutenberg the opposite. This is one area where the same string can be used in two different places. The issue is that at some point the guideline here should be consistent between Core and Gutenberg but it's a broader issue.
|
This is what I see: Creating-Reusable-blocks.mp4Should the drop down seen in the background close before the modal is seen? Btw |
|
Yes, the dropdown should stay open in case you cancel, the focus is moved back there. |
|
Late to the party but very happy to see this; thanks @youknowriad ❤️ |
This was referenced Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12940
Implements the flow discussed in #12940 for reusable blocks.
This new reusable block creation flow has three advantages:
untitled-reusable-block-xxxThis flow is likely to be applied to template parts as well.