Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preformatted block: Add color controls. #28396

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Jan 21, 2021

Description

Add color controls for the preformatted block. When the block is using background, I'm adding some padding. Fixes #28098

How has this been tested?

Tested using the block and changing colors while using twentytwentyone.

Screenshots

Types of changes

New feature (non-breaking change which adds functionality).

Checklist:

  • My code is tested.
  • [ x] My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Base automatically changed from master to trunk March 1, 2021 15:45
@paaljoachim
Copy link
Contributor

Hi @juanfra Juan

Let us know how we can help.

@juanfra
Copy link
Member Author

juanfra commented Mar 25, 2021

Hi @paaljoachim!

Thanks for looking into this, I fixed the merge conflict. This is ready to be reviewed.

@gwwar gwwar self-requested a review March 25, 2021 18:36
@paaljoachim
Copy link
Contributor

Hi @juanfra Juan

Perhaps after this PR has been merged that you can continue with:
File Block: Add background/text color support
#18989

Thank you for your help in adding these controls!

@juanfra
Copy link
Member Author

juanfra commented Mar 26, 2021

@paaljoachim sure! will try to find some time for that in the upcoming days.

Copy link
Contributor

@gwwar gwwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me. Thanks for the contribution @juanfra !

@gwwar gwwar merged commit 16c4103 into WordPress:trunk Mar 26, 2021
@github-actions github-actions bot added this to the Gutenberg 10.4 milestone Mar 26, 2021
@juanfra juanfra deleted the fix/28098-preformatted-color branch March 27, 2021 09:05
@paaljoachim
Copy link
Contributor

Hi @juanfra Juan

We need to make a correction to the File block I linked to. It needs Color and Typography controls (not only color controls). Just like the Buttons block here needs Color and Typography controls. #29112

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preformatted block: Missing color controls
3 participants