Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons block: Missing typography controls #29112

Closed
paaljoachim opened this issue Feb 18, 2021 · 3 comments
Closed

Buttons block: Missing typography controls #29112

paaljoachim opened this issue Feb 18, 2021 · 3 comments
Labels
[Block] Buttons Affects the Buttons Block Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

We are adding typography and color controls to the text blocks that still do not have these features.

This issue is focused on the Buttons block that still needs typography controls.

Screen Shot 2021-02-18 at 13 22 04

Associated issue:
Consider adding color and text size customizations to all text-based blocks.
#8171
@paaljoachim paaljoachim added [Block] Buttons Affects the Buttons Block [Type] Enhancement A suggestion for improvement. Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts labels Feb 18, 2021
This was referenced Feb 18, 2021
Closed
Closed
@paaljoachim paaljoachim mentioned this issue Mar 30, 2021
Merged
5 tasks
@lukecarbis lukecarbis mentioned this issue Mar 30, 2021
Merged
7 tasks
@Mamaduka Mamaduka added the [Status] In Progress Tracking issues with work in progress label Mar 31, 2021
@paaljoachim
Copy link
Contributor Author

paaljoachim commented Apr 7, 2021 •
edited
Loading

Typography controls in the Buttons block has now been merged!

@mhbManchester
Copy link

The buttons block module is pretty primitive. It isn't possible to change the fonts - the preferred theme font gets overridden by a horrible serif font. Adding html usually results in an error.

@paaljoachim
Copy link
Contributor Author

Hey @mhbManchester

It would be great if you can open a new issue for this.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Buttons Affects the Buttons Block Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mamaduka @paaljoachim @mhbManchester