Adds in styling for post comments form #27009
Conversation
karmatosed
added
Needs Design Feedback
karmatosed
requested review from
ajitbohra,
Soean and
talldan
as code owners
|
Size Change: +249 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
|
Thank you for this PR, we were discussing this last week @scruffian Should we also consider the styles for the form when the user is not logged in on this PR?
|
|
@MaggieCabrera thanks for your feedback.
Probably if we do provide styling it should be done for all states. This is where though finding how far we want to go with the default styling is a great conversation to be had. |
I like the direction your PR is going and I believe this should translate to the frontend as well. During our week experimenting with block-based themes, we were using this boilerplate theme as a base and we noticed how broken the comments were. In my opinion, we should provide a base for the themes to work upon, not have them built it from scratch every single time. |
| width: 100%; | ||
| } | ||
|
|
||
| #submit{ |
There was a problem hiding this comment.
Could this implement a button block?
|
+1 to what @MaggieCabrera said. I think it's also important to consider what parts of this users will want to customize themselves. I wonder if it makes sense for lots of these elements to be child blocks so they can benefit from the same customizations that other blocks have. |
|
Hi @karmatosed, are you interested in picking this up again? |
|
@carolinan happy to, I can look at it this week. |
There was a problem hiding this comment.
I know this PR is quite outdated and @karmatosed is likely to be taking another pass soon. So, please ignore my code review comments if no longer pertinent.
Also, worth noting that there may some minor overlap here with Global Styles: Form elements #29167
| @@ -0,0 +1,30 @@ | |||
| .wp-block-post-comments-form { | |||
|
|
|||
| h3#reply-title { | |||
There was a problem hiding this comment.
Can we avoid this specificity?
| h3#reply-title { | ||
| margin-top: $grid-unit-20; | ||
| } | ||
|
|
There was a problem hiding this comment.
Same here - avoid element selector if possible please?
|
I am having quite some time getting this PR working right now so going to close and create new one as this got incredibly stale. I'll link a fresh version though - turns out a lot happens in nearly a year to make PRs out of date (which is awesome). |
This is an initial PR, but will need some iteration based on feedback, provides a step towards a solution for #26865.
Before:
After:
Showing the block style and non-block style:
In the PR this explicity is styled only around the block class, but this might not be desireable so noting this here. This theme is experimental so please ignore the message about comments.php seen, I am simply using it to illustrate both.
Mobile:
Feedback
There are a few things not done in this PR and a few questions, the code also needs a review.
Along with this I would love some feedback, if nothing else this PR showed the limits of what was possible and the CSS needed to get there for this block.