Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Comments Form Block: Block should ship with default styles #26865

Closed
kjellr opened this issue Nov 10, 2020 · 3 comments · Fixed by #35704
Closed

Post Comments Form Block: Block should ship with default styles #26865

kjellr opened this issue Nov 10, 2020 · 3 comments · Fixed by #35704
Assignees
Labels
[Block] Post Comments Form Affects the Comments Form Block CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Enhancement A suggestion for improvement.

Comments

@kjellr
Copy link
Contributor

kjellr commented Nov 10, 2020

The post comments form block currently renders completely unstyled:

Screen Shot 2020-11-10 at 1 40 57 PM

This should ship with a set of default styles so it can be used out of the box in block-based themes.

@kjellr kjellr added [Type] Enhancement A suggestion for improvement. Needs Design Needs design efforts. [Block] Post Comments Form Affects the Comments Form Block labels Nov 10, 2020
@aristath aristath added [Feature] Full Site Editing [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. CSS Styling Related to editor and front end styles, CSS-specific issues. labels Nov 11, 2020
@karmatosed karmatosed self-assigned this Nov 11, 2020
@kjellr
Copy link
Contributor Author

kjellr commented Nov 12, 2020

One wishlist item for this: The button block should inherit the standard wp-block-button styles.

Ideally, it would be an actual nested (variation of a) button block, so that users could modify its appearance.

@karmatosed
Copy link
Member

@kjellr I took a little time in mocking this up and will spin up a PR to get iterations going as hopefully most can be done in CSS (yet to confirm that).

Suggestion

I went really simple using the grid variables for spacing and default scale for typography. This should also allow easier customization of this in the future.

simpl1

Relating to customizing, here is what coloring that slightly could for example lead to, this could just be done using variable changes:

simpl2

I did noticed that the placeholder for the post comments form is also a little sparce, so opened an issue #26999.

Feedback

I'm looking for any feedback, but specifically is this giving the flexibility needed along with tidying up?

@karmatosed karmatosed added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels Nov 16, 2020
@kjellr
Copy link
Contributor Author

kjellr commented Nov 16, 2020

This seems like a good start, thanks @karmatosed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Comments Form Affects the Comments Form Block CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants