Extract inserter state into reusable hooks #22710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Inserter
|
Size Change: +104 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
packages/block-editor/src/components/inserter/hooks/use-block-types-state.js
Show resolved
Hide resolved
packages/block-editor/src/components/inserter/hooks/use-block-types-state.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/inserter/hooks/use-insertion-point.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/inserter/hooks/use-insertion-point.js
Outdated
Show resolved
Hide resolved
youknowriad
force-pushed
the
refactor/inserter-state
branch
from
8076e6e
to
120daec
Compare
|
Going to merge this so I can unblock my inserter work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As aI was working n #21080 to implement a new quick inserter. I noticed that I was duplicating lot of existing code from the global inserter. This PR extracts the inserter state behavior into three React hooks to allow reusing them to build different kinds of inserters.
useInsertionPoint: takes the inserter config and returns the destination position (clientId) and callbacks to call to toggle the insertion point visibility and to insert blocks into the insertion point.
useBlockTypesState: given the onInsertBlocks callback from the previous hook, it returns the list of block types to show in the inserter and a callback to call when clicking these block types (to insert them)
usePattersState: equivalent to useBlockTypesState but for patters.
Testing instructions
I personally trust e2e tests here to catch potential errors.